Page MenuHomePhabricator
Create Task
Maniphest T301619

Replace use of deprecated ParserOutput::{get,set,unset}Property
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/727401 / T287216 renames the function ParserOutput::{get,set,unset}Property to ParserOutput::{get,set,unset}PageProperty

Extension and skins needs to be changed to avoid CI errors due to the hard deprecation message making phpunit tests failing

Soft deprecation and hard deprecation are in the same version. All replacement should be in a backward compatible way or the required version in extension.json needs to be 1.38 (or higher)

Codesearch to find usage (the function name are more common and only searching for the name gives many other findings - about 1000)

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Feb 12 2022, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2022, 6:53 PM
Umherirrender added a parent task: T287216: ParserOutput should implement ContentMetadataCollector.Feb 12 2022, 6:53 PM
Umherirrender added a subtask: T293560: IndexFunction uses deprecated direct access to PHP properties on ParserOutput.
gerritbot added a comment.Feb 12 2022, 7:13 PM

Change 762036 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Interlanguage@master] Use array style on adding modules to ParserOutput

https://gerrit.wikimedia.org/r/762036

gerritbot added a project: Patch-For-Review.Feb 12 2022, 7:13 PM
gerritbot added a comment.Feb 12 2022, 7:15 PM

Change 762081 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DocBookExport@master] Replaced deprecated Parser::setProperty

https://gerrit.wikimedia.org/r/762081

gerritbot added a comment.Feb 12 2022, 7:16 PM

Change 762082 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GraphViz@master] Replaced deprecated Parser::setProperty

https://gerrit.wikimedia.org/r/762082

gerritbot added a comment.Feb 12 2022, 7:16 PM

Change 762083 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageLanguage@master] Replaced deprecated Parser::getProperty

https://gerrit.wikimedia.org/r/762083

gerritbot added a comment.Feb 12 2022, 7:17 PM

Change 762084 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageSchemas@master] Replaced deprecated Parser::setProperty

https://gerrit.wikimedia.org/r/762084

gerritbot added a comment.Feb 12 2022, 7:18 PM

Change 762085 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LinkedWiki@master] Replaced deprecated Parser::setProperty

https://gerrit.wikimedia.org/r/762085

gerritbot added a comment.Feb 12 2022, 7:18 PM

Change 762029 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceChecklist@master] Use array style on adding modules to ParserOutput

https://gerrit.wikimedia.org/r/762029

gerritbot added a comment.Feb 12 2022, 7:20 PM

Change 762086 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SemanticDrilldown@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762086

gerritbot added a comment.Feb 12 2022, 7:24 PM

Change 762087 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ApprovedRevs@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762087

gerritbot added a comment.Feb 12 2022, 7:25 PM

Change 762088 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/StructuredNavigation@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762088

gerritbot added a comment.Feb 12 2022, 7:29 PM

Change 762089 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cargo@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762089

gerritbot added a comment.Feb 12 2022, 7:33 PM

Change 762090 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MintyDocs@master] Replaced deprecated ParserOutput::getProperty

https://gerrit.wikimedia.org/r/762090

gerritbot added a comment.Feb 14 2022, 3:14 AM

Change 762084 merged by jenkins-bot:

[mediawiki/extensions/PageSchemas@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762084

gerritbot added a comment.Feb 14 2022, 3:15 AM

Change 762089 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762089

gerritbot added a comment.Feb 14 2022, 3:20 AM

Change 762087 merged by jenkins-bot:

[mediawiki/extensions/ApprovedRevs@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762087

gerritbot added a comment.Feb 14 2022, 3:24 AM

Change 762086 merged by jenkins-bot:

[mediawiki/extensions/SemanticDrilldown@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762086

gerritbot added a comment.Feb 14 2022, 4:43 AM

Change 762090 merged by jenkins-bot:

[mediawiki/extensions/MintyDocs@master] Replaced deprecated ParserOutput::getProperty

https://gerrit.wikimedia.org/r/762090

Umherirrender mentioned this in rEMDO418e9eef7a0a: Replaced deprecated ParserOutput::getProperty.Feb 14 2022, 4:46 AM
gerritbot added a comment.Feb 14 2022, 7:46 AM

Change 762029 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceChecklist@master] Use array style on adding modules to ParserOutput

https://gerrit.wikimedia.org/r/762029

Umherirrender mentioned this in rEBTAcd0f3f5731de: Use array style on adding modules to ParserOutput.Feb 14 2022, 7:48 AM
gerritbot added a comment.Feb 15 2022, 12:48 AM

Change 762036 merged by jenkins-bot:

[mediawiki/extensions/Interlanguage@master] Use array style on adding modules to ParserOutput

https://gerrit.wikimedia.org/r/762036

gerritbot added a comment.Feb 15 2022, 12:51 AM

Change 762083 merged by jenkins-bot:

[mediawiki/extensions/PageLanguage@master] Replaced deprecated ParserOutput::getProperty

https://gerrit.wikimedia.org/r/762083

gerritbot added a comment.Feb 15 2022, 12:52 AM

Change 762081 merged by jenkins-bot:

[mediawiki/extensions/DocBookExport@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762081

gerritbot added a comment.Feb 15 2022, 12:52 AM

Change 762082 merged by jenkins-bot:

[mediawiki/extensions/GraphViz@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762082

Umherirrender mentioned this in rEDBE1009abc84ed7: Replaced deprecated ParserOutput::setProperty.Feb 15 2022, 12:55 AM
gerritbot added a comment.Feb 15 2022, 12:57 AM

Change 762085 merged by jenkins-bot:

[mediawiki/extensions/LinkedWiki@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762085

Zabe mentioned this in rELIWf77642f1f29a: Replaced deprecated ParserOutput::setProperty.Feb 15 2022, 1:16 AM
Umherirrender mentioned this in rEPLA16c551eac0df: Replaced deprecated ParserOutput::getProperty.Feb 15 2022, 1:26 AM
gerritbot added a comment.Feb 19 2022, 1:45 PM

Change 762088 merged by Umherirrender:

[mediawiki/extensions/StructuredNavigation@master] Replaced deprecated ParserOutput::setProperty

https://gerrit.wikimedia.org/r/762088

Umherirrender mentioned this in rESNV2c6da82daa82: Replaced deprecated ParserOutput::setProperty.Feb 19 2022, 2:07 PM
Umherirrender closed this task as Resolved.Mar 15 2022, 10:19 PM
Umherirrender removed a project: Patch-For-Review.
cscott removed a subtask: T293560: IndexFunction uses deprecated direct access to PHP properties on ParserOutput.Mar 31 2022, 3:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL