Page MenuHomePhabricator

GlobalBlocking purge expired must have a limit
Closed, ResolvedPublic

Description

Currently this is the second biggest write query changing more than 1000 rows. In one case I checked it removed > 19,000 in query which can easily make wikis go read-only. This needs batching.
https://logstash.wikimedia.org/goto/f4c2e73ced8a93ada202f981118284aa

Event Timeline

Change 762134 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalBlocking@master] Use primary key and limit for purge of expired blocks

https://gerrit.wikimedia.org/r/762134

Umherirrender added a subscriber: Umherirrender.

If there are so much row to delete, that could mean the current intervall of deletion is too less.

Maybe a maintenance script is needed for that purpose. Or the deletion needs to be done in a job queue to retrigger the job if there are still rows to delete. But that should be discussed separated.

Change 762134 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use primary key and limit for purge of expired blocks

https://gerrit.wikimedia.org/r/762134