Page MenuHomePhabricator
Create Task
Maniphest T301651

De-duplicate the action reason dropdown building code, which is copied around multiple times
Open, LowPublic
Actions

Description

Screenshot 2022-02-13 at 21-38-46 Delete Category Foo - Trunk Test.png (1,261×687 px, 70 KB)

The code that builds this dropdown has been copied from DeleteAction to the RevisionCommentSupplement extension (incorrectly), Translate, and now, Nuke (see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Nuke/+/758037). Complicating matters, it's also used in FileDeleteAction but with different messages using inheritance and constant overrides.

Codesearch: https://codesearch.wmcloud.org/search/?q=deletereason-dropdown&i=nope&files=.php%24&excludeFiles=&repos=

This code should be refactored so extensions can reuse this without having to reimplement/copy it all.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
resources: Create mw.widgets.visibleCodePointLimitWithDropdownUmherirrendermediawiki/coremaster+108 -153
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Feb 14 2022, 5:42 AM
Legoktm triaged this task as Low priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2022, 5:42 AM
Umherirrender subscribed.Mar 5 2024, 11:29 PM

Special:Block is using a similiar reason dropdown via the HTMLSelectAndOtherField as part of a HTMLForm.

This also exists on the following pages, with different select and text htmlform inputs or directly with OOUI text and select widgets.

These usages have a extra label between the dropdown and the text input. selectandother does not.
Some of them using two messages to provide the options, depending on user rrights. selectandother supports one message, but would accept options parsed outside of the form (combined and parsed with Xml::listDropDownOptions)

Jdforrester-WMF renamed this task from Delete reason dropdown building code copied around multiple times to De-duplicate the action reason dropdown building code, which is copied around multiple times.Mar 6 2024, 10:25 PM
Jdforrester-WMF added a project: MediaWiki-User-Interface (actions).
Jdforrester-WMF subscribed.
• matmarex subscribed.Mar 6 2024, 10:28 PM
Tacsipacsi subscribed.Mar 7 2024, 4:09 PM
gerritbot added a comment.Mar 7 2024, 9:34 PM

Change 1009610 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] resources: Create mw.widgets.visibleCodePointLimitWithDropDown

https://gerrit.wikimedia.org/r/1009610

gerritbot added a project: Patch-For-Review.Mar 7 2024, 9:34 PM
gerritbot added a comment.Mar 9 2024, 1:24 AM

Change 1009610 merged by jenkins-bot:

[mediawiki/core@master] resources: Create mw.widgets.visibleCodePointLimitWithDropdown

https://gerrit.wikimedia.org/r/1009610

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2024, 1:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 9 2024, 6:00 AM
Umherirrender unsubscribed.Sep 3 2024, 7:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits