List of steps to reproduce (step by step, including full links if applicable):
- ensure the NSFileRepo extension is installed (I know, but bear with me please)
- upload a file and try to move it to another namespace (which is the main feature of NSFileRepo)
- an error will be returned involving $this->logger->debug on line 192 of includes/filerepo/file/LocalFileMoveBatch.php
The error mentioned results from the fact that the NSFileRepo's NSLocalFile->move() function cannot set the $logger parameter of the LocalFileMoveBatch parent class.
This stems from the fact that LocalFileMoveBatch defines the $logger parameter as private rather than protected.
What should have happened instead?:
The NSFileRepo based file move should still be able to work (despite the lack of maintenance to this extension).
To fix it, all I'm asking is for the $logger parameter of the LocalFileMoveBatch class (includes/filerepo/file/LocalFileMoveBatch.php) to be set to protected rather than private.
Once this is done, NSFileRepo can work again (and I can confirm that I have succeeded with that).
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Currently using 1.37.1, but I know this problem also existed in 1.36.