Page MenuHomePhabricator

Allow Special:ListObjectsByType/Z8 to let you filter by the return type of the function too
Open, MediumPublic

Description

Notes for implementation:

  • Pass the requested return type into ZObjectStore::searchZObjectLabels() parameter $returnType.
  • Maybe prompt the user with 'sensible' standard options (Z6/String, Z40/Boolean, others?) as well as a type-select input?
  • Maybe a checkbox to allow things that are badged as returning a Z1 too?

Event Timeline

I think it might be cleaner to have a special page for listing functions which has more filters, e.g.

  • return type
  • argument types
  • number of arguments?
  • does it have implementations? connected implementations? disconnected ones?
  • same for tests

These are so specific to Functions, that it probably does not make sense to integrate this in this rather simple type listing page. Or else we might run the risk of having a lot of filtering happening here, if we start doing that for other types.

So suggestion is to introduce a Special:ListFunctions page, that then can have those filters.

UI-wise we could drive inspiration from the user contributions page et similar where there is an accordion at the top of the page with bespoke filters based on the page type.

image.png (1×1 px, 166 KB)

does it have implementations? connected implementations? disconnected ones?
same for tests

See: T343565: Have a way to find a list of functions without something

We should also consider finding functions with or without labels in a particular language. Perhaps those with labels in a fallback language other than (prior to) English would be an interesting further division, indicating the fallback language.

An indication of how completely a function as a whole is represented in a given language would also be useful, but we need to consider that some Test cases and Implementations are reasonably self-explanatory and better support for more self-explanatory default labels might be a higher priority. I would be inclined to ignore Implementations and Test cases for now and focus on the function’s input labels and Keys. (Input and output labels should be added to the function model in due course.)

Jdforrester-WMF renamed this task from Allow Special:ListZObjectsByType/Z8 to let you filter by the return type of the function too to Allow Special:ListObjectsByType/Z8 to let you filter by the return type of the function too.Wed, Apr 10, 3:01 PM