Maniphest T301723

Add the SkinComponentSearch component
Closed, ResolvedPublic
Actions

Description

NOTE: Since this removes SkinTemplate::getSearchInputAttributes adding in the same release cycle this blocks the 1.38 release.

Acceptance criteria

The SkinComponentSearch component is added.
SkinTemplate::getSearchInputAttributes introduced in 1.38 is removed in 1.38 given it was never released or used.
Skin::makeSearchInput and Skin::makeSearchButton should be hard deprecated.
Methods should be moved to SkinTemplate where needed to support skins using BaseTemplate to avoids deprecation warnings in Timeless.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Introduce SkinComponentSearch	mediawiki/core	master	+493 -124
	Update deprecation notes and warnings for 1.39	mediawiki/core	master	+7 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T263213 Data shared between SkinMustache and SkinTemplate should be common
		Resolved		Jdlrobson	T301723 Add the SkinComponentSearch component

Event Timeline

Jdlrobson created this task.Feb 14 2022, 8:28 PM

Jdlrobson triaged this task as High priority.

Change 744105 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Introduce SkinComponentSearch

https://gerrit.wikimedia.org/r/744105

gerritbot added a project: Patch-For-Review.Feb 14 2022, 8:28 PM

Jdlrobson moved this task from Backlog to Componentize skins on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Feb 14 2022, 8:32 PM

Note this is a 1.38 release blocker as we want to remove SkinTemplate::getSearchInputAttributes which was introduced in this same release.

I've submitted https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764876 which @Ammarpad has merged (thanks!) so this is no longer a release blocker.

Work here is being blocked by T305081.

Change 744105 merged by jenkins-bot:

[mediawiki/core@master] Introduce SkinComponentSearch

https://gerrit.wikimedia.org/r/744105

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 31 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2022, 4:10 PM

Jdlrobson updated the task description. (Show Details)Mar 31 2022, 11:21 PM

Change 776013 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Update deprecation notes and warnings for 1.39

https://gerrit.wikimedia.org/r/776013

gerritbot added a project: Patch-For-Review.Mar 31 2022, 11:23 PM

Change 776013 merged by jenkins-bot:

[mediawiki/core@master] Update deprecation notes and warnings for 1.39

https://gerrit.wikimedia.org/r/776013

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2022, 1:10 AM

Jdlrobson closed this task as Resolved.Apr 1 2022, 2:52 PM

Jdlrobson claimed this task.

Jdlrobson added a project: Web-Team-Backlog-Archived (Kanbanana-FY-2021-22).

Jdlrobson updated the task description. (Show Details)

ashley mentioned this in T327821: Skin#makeSearchButton does not output a value="" attribute anymore, resulting in confusing user-facing output.Jan 24 2023, 9:47 PM