Page MenuHomePhabricator

Add the SkinComponentSearch component
Closed, ResolvedPublic

Description

NOTE: Since this removes SkinTemplate::getSearchInputAttributes adding in the same release cycle this blocks the 1.38 release.

Acceptance criteria

  • The SkinComponentSearch component is added.
  • SkinTemplate::getSearchInputAttributes introduced in 1.38 is removed in 1.38 given it was never released or used.
  • Skin::makeSearchInput and Skin::makeSearchButton should be hard deprecated.
  • Methods should be moved to SkinTemplate where needed to support skins using BaseTemplate to avoids deprecation warnings in Timeless.

Event Timeline

Jdlrobson triaged this task as High priority.

Change 744105 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Introduce SkinComponentSearch

https://gerrit.wikimedia.org/r/744105

Note this is a 1.38 release blocker as we want to remove SkinTemplate::getSearchInputAttributes which was introduced in this same release.

I've submitted https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764876 which @Ammarpad has merged (thanks!) so this is no longer a release blocker.

Change 744105 merged by jenkins-bot:

[mediawiki/core@master] Introduce SkinComponentSearch

https://gerrit.wikimedia.org/r/744105

Change 776013 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Update deprecation notes and warnings for 1.39

https://gerrit.wikimedia.org/r/776013

Change 776013 merged by jenkins-bot:

[mediawiki/core@master] Update deprecation notes and warnings for 1.39

https://gerrit.wikimedia.org/r/776013

Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)