Maniphest T301729

Make Skin::preloadExistence private
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 14 2022, 9:21 PM

Tags

Referenced Files

None

Subscribers

Description

No need for this to be protected.

No known usages so should be safe to do this now without any deprecation steps.

Details

	Subject	Repo	Branch	Lines +/-
	Make Skin::preloadExistence private	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T299099: Question: Is Skin::preloadExistence still relevant?

Event Timeline

Jdlrobson created this task.Feb 14 2022, 9:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2022, 9:21 PM

Jdlrobson triaged this task as High priority.Feb 14 2022, 9:21 PM

Jdlrobson mentioned this in T299099: Question: Is Skin::preloadExistence still relevant?.

Note: In future we may want to consider moving this functionality to OutputPage::outputPage

Jdlrobson moved this task from Backlog to Menu prep work on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Feb 18 2022, 9:40 PM

Change 763914 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Make Skin::preloadExistence private

https://gerrit.wikimedia.org/r/763914

gerritbot added a project: Patch-For-Review.Feb 19 2022, 6:57 PM

Change 763914 merged by jenkins-bot:

[mediawiki/core@master] Make Skin::preloadExistence private

https://gerrit.wikimedia.org/r/763914

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 21 2022, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2022, 11:10 PM

🥳
Thanks @Ammarpad!