Page MenuHomePhabricator

Add read and write implementations for Sofort payments to PaymentRepository
Closed, ResolvedPublic5 Estimated Story Points

Description

Acceptance Criteria

  • The domain objects are refactored according to the data model. You can leave other payment objects in a semi-broken state as long as all remaining tests still pass and the next steps are clear (i.e. putting TODOs/commented-out code in classes, skipping tests).
  • The implementation of the PaymentRepository interface implements storing and retrieving payments with sofort. All other payment methods may throw "Not implemented" logic exceptions for now.
  • The changes outlined in T281895: Make SofortPayment::confirmedAt immutable are no longer necessary/solved according to the domain specification

Implementation Details

  • Refactor SofortPayment and SofortTransactionData as needed, with a similar pattern used as in the credit card modeling case.

Event Timeline

gabriel-wmde set the point value for this task to 5.Feb 21 2022, 11:07 AM

Moved task back to "TODO" because the tests are missing - they have been deactivated and exlcuded from PHPStan, so that slipped through

AbbanWMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2022-03-21 board.
AbbanWMDE subscribed.