Page MenuHomePhabricator

ULS button in personal bar broken with classic vector
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

On https://beta.wikiversity.org/wiki/Main_Page?useskin=vector the first click on ULS does nothing. The second click works as expected.

Old report (resolved):

With $wgULSPosition left to the default value of personal:
On load:

image.png (118×419 px, 9 KB)

After clicking once, the icon changes size, but the overlay doesn't load:

image.png (114×413 px, 9 KB)

The second click does nothing, and only on the third click does the language selector appear.

Most WMF wikis have $wgULSPosition set to interlanguage where it isn't broken, but some don't:

'wmgULSPosition' => [
	'default' => 'interlanguage',
	'special' => 'personal',
	'wikimedia' => 'personal',
	'betawikiversity' => 'personal',
]

Event Timeline

Esanders renamed this task from Double language icon in ULS selector with new vector to ULS button broken with new vector.Feb 16 2022, 3:27 PM
Esanders updated the task description. (Show Details)
Jdlrobson added subscribers: Nikerabbit, Jdlrobson.

@Esanders is there a production URL I can test this? I'm not sure what special and wikimedia refer to in config and I can't replicate on https://beta.wikiversity.org/wiki/Main_Page?useskin=vector-2022

However, there is no "personal" bar in Vector, so @Nikerabbit I'm guessing this should probably throw an exception for Vector 2022 skin or fallback to something that is supported.

I can partially reproduce on https://beta.wikiversity.org/wiki/Main_Page?useskin=vector where first click doesn open the dialog.

Having updated by ULS repo (doh) this appears to have been resolved. @Nikerabbit's issue with classic vector appears to be valid though.

Esanders renamed this task from ULS button broken with new vector to ULS button in personal bar broken with classic vector.Feb 24 2022, 2:33 PM
Esanders updated the task description. (Show Details)
Nikerabbit set the point value for this task to 2.Mar 1 2022, 8:18 AM
Nikerabbit changed the subtype of this task from "Task" to "Bug Report".Mar 1 2022, 9:43 AM

Change 767874 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] Delay click trigger when loading uls.languagesettings first time

https://gerrit.wikimedia.org/r/767874

abi_ changed the task status from Open to In Progress.Mar 3 2022, 8:24 PM
abi_ claimed this task.

Change 767874 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Stop propagating first click handler when loading languagesettings

https://gerrit.wikimedia.org/r/767874

This is now fixed. Tested on: https://beta.wikiversity.org/wiki/Main_Page?useskin=vector

This issue was occurring when the user is not logged in, ULSPosition is personal, and ULSAnonCanChangeLanguage is false.