Page MenuHomePhabricator

Vector should use list-style: disc before its list-style-image declaration to support browsers with images disabled
Open, MediumPublicFeature

Description

See also: T234400

For some reason, images frequently refuse to load for me on Wikimedia websites lately. After encountering this, I have noticed an easy fix to make the no-image experience more visually consistent:

ul {
	list-style-image:url(/w/skins/Vector/resources/common/images/bullet-icon.svg?d4515)
}

This declaration from Vector’s CSS should have list-style: disc (or similar) added before it so that the lists are rendered consistently with black dots. Currently sub-lists are rendered with white dots (at least in Firefox), which is noticeable on pages with a lot of sub-lists, for example:
https://ru.wikipedia.org/wiki/Википедия:Форум/Общий

(This is a fairly simple and non-important change overall, and I hope my issues with image loading stop one day.)

Event Timeline

Which Vector skin is this bug for? The new or old one?

Both? I don’t think styles for ul are different in two skin versions.

Hi, @Jdlrobson and @stjn I'm interested to solve this issue but in chrome browser sublists are
rendering with black dots as-

WhatsApp Image 2022-03-15 at 5.25.30 PM.jpeg (607×1 px, 143 KB)
could you explain me the problem more so I move ahead, waiting for your kind response.

Currently sub-lists are rendered with white dots (at least in Firefox),

@stjn: Could you please provide a screenshot, plus provide browser version information? Thanks.

Just disable images in any browser (I assume), or just latest Firefox.

I can't replicate. A screenshot would be helpful.

Just disable images in any browser (I assume), or just latest Firefox.

Disable how exactly? Cannot reproduce in Firefox 98.0 (without changing...something somewhere).

Jdlrobson renamed this task from Vector should use list-style: disc before its list-style-image declaration to Vector should use list-style: disc before its list-style-image declaration to support browsers with images disabled.Mar 16 2022, 7:18 PM
Jdlrobson added a project: UI-Standardization.
Jdlrobson added a subscriber: Volker_E.

For some reason, images frequently refuse to load for me on Wikimedia websites lately.

This seems like a bigger concern to me. Why are images refusing to load - is that a problem with our servers, a gadget, or an issue isolated to you? I think gracefully degrading to a disc makes sense regardless. cc @Volker_E

I can't replicate. A screenshot would be helpful.

Three different ones in a screenshot, for example:

image.png (874×2 px, 247 KB)

Either way, this is not such a huge change that it needs to be so meticulously discussed. I simply proposed a solution to a small bug (of using an image but not providing a fallback for it).

This seems like a bigger concern to me. Why are images refusing to load - is that a problem with our servers, a gadget, or an issue isolated to you?

Can’t answer this. It happens occasionally. I am not sure what exactly causes it. Certainly not a location problem or something, and should not be a device ratio problem either (since SVG images also don’t load in those circumstances, like in this case).