| Jdlrobson | |
| Feb 17 2022, 6:24 PM |
| F34983004: Screen Shot 2022-03-07 at 5.32.57 PM.png | |
| Mar 8 2022, 1:34 AM |
| F34983005: Screen Shot 2022-03-07 at 5.32.41 PM.png | |
| Mar 8 2022, 1:34 AM |
| F34973033: Screen Shot 2022-03-02 at 4.23.57 PM.png | |
| Mar 3 2022, 12:27 AM |
| F34973034: Screen Shot 2022-03-02 at 4.25.14 PM.png | |
| Mar 3 2022, 12:27 AM |
| F34973038: Screen Shot 2022-03-02 at 4.23.39 PM.png | |
| Mar 3 2022, 12:27 AM |
| F34973037: Screen Shot 2022-03-02 at 4.23.25 PM.png | |
| Mar 3 2022, 12:27 AM |
| F34972477: Screen Shot 2022-03-02 at 7.36.45 AM.png | |
| Mar 2 2022, 3:38 PM |
| F34972478: Screen Shot 2022-03-02 at 7.36.22 AM.png | |
| Mar 2 2022, 3:38 PM |
The language sidebar box is showing up on https://fr.wikipedia.org/wiki/Projet_de_constitution_fran%C3%A7aise_du_19_avril_1946 per @Patafisik report. This should have been fixed in 1.38.0-wmf.20 on T295555
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T302018#7758971 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix language alert regression | mediawiki/skins/Vector | wmf/1.38.0-wmf.24 | +191 -4 | |
| Fix language alert regression | mediawiki/skins/Vector | master | +191 -4 |
Change 763853 had a related patch set uploaded (by Clare Ming; author: Clare Ming):
[mediawiki/skins/Vector@master] Fix language alert regression
I think what's happening here is that https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/Vector/+/refs/heads/master/includes/SkinVector.php#869 adds a class to hide the language button which isn't accounted for in the check to display the language alert.
Change 763853 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix language alert regression
Status: ❌
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
❌ AC1: Language notice should not show up for pages with only one language.
The language notice does not show up when logged in, but it does show up when anon.
@nray I assigned it to you because as best as I could tell you worked on it. Feel free to reassign or clarify if the anon behavior is correct.
hi @Edtadros -- can you test again with a query param to break the cache? if you open up that Spain page in beta as anon with a fake query param, the language alert does not show as intended. Also similar pages (i.e. without language button in header) seem to work as intended as well whether logged in or as anon -- https://en.wikipedia.beta.wmflabs.org/wiki/Germany)
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?foo=bar
thanks to @nray for the hint on breaking cache (see thread in https://wikimedia.slack.com/archives/G8QAPHCTT/p1646237206910449)
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Language notice should not show up for pages with only one language.
Change 768786 had a related patch set uploaded (by Clare Ming; author: Clare Ming):
[mediawiki/skins/Vector@wmf/1.38.0-wmf.24] Fix language alert regression
Change 768786 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.38.0-wmf.24] Fix language alert regression
Mentioned in SAL (#wikimedia-operations) [2022-03-07T21:37:36Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.24/skins/Vector/includes/SkinVector.php: eac551c: Fix language alert regression (T302018) (duration: 00m 50s)
Status: ✅ PASS
Environment: enwiki, frwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Language notice should not show up for pages with only one language.
