Page MenuHomePhabricator
Create Task
Maniphest T302045

monitoring alert: legal footer change on en.wikipedia - due to creative commons license version change
Closed, ResolvedPublic
Actions

Description

A recent wiki edit on en.wikipedia changed the license version in the footer.

A long time ago legal had requested from Operations (before it was SRE) to add a monitoring check to make sure the legal footer does NOT change.

So now it is alerting.

Questions here for legal are:

  • does it matter to you that the version changed to 3.0?
  • do you still want this kind of monitoring and should we contact you if it happens again?
  • should we just adjust the monitoring so that from now on the new version is the expected one?
  • is it good or bad that it alerts on every version change in the future?
23:05 <+icinga-wm> PROBLEM - Ensure legal html en.wp on en.wikipedia.org is CRITICAL: 
Text\sis\savailable\sunder\sthe\sa\srel=license\s+href=(https:)?\/\/en.wikipedia.org\/wiki\/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_LicenseCreative\sCommons\sAttribution-ShareAlike\sLicense/aa\srel=license\shref=\/\/creativecommons.org\/licenses\/by-sa\/3\.0/ html not found https://phabricator.wikimedia.org/project/members/28/

23:05 < mutante> ^ duh.. those are content checks on wiki
23:05 < mutante> somebody edited a footer maybe
23:10 < AntiComposite> yup, this is what cause the legal html alert https://en.wikipedia.org/w/index.php?title=MediaWiki:Wikimedia-copyright&diff=1072378717&oldid=861624479&diffmode=source
23:11 < RhinosF1> AntiComposite: should it be reverted?
23:11 < AntiComposite> probably not
23:11 < AntiComposite> CC license statements are supposed to have the version in them
23:12 < mutante> ah, Thanks for that AntiComposite 
23:12 < mutante> then the monitoring needs to be adjusted
23:13 < mutante> hardcoding a version isn't ideal for a check like that   (later comment: or IT IS exactly what is supposed to happen for a legal check)

prod alert https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=en.wikipedia.org&service=Ensure+legal+html+en.wp

phabricator project for legal team members who wanted to monitor this https://phabricator.wikimedia.org/project/members/28/

change that caused the new alert https://en.wikipedia.org/w/index.php?title=MediaWiki:Wikimedia-copyright&diff=1072378717&oldid=861624479&diffmode=source

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+1 -1icinga: fix "legal check" monitoring footer HTML on en.wikipedia
Customize query in gerrit

Related Objects

Event Timeline

Dzahn created this task.Feb 17 2022, 11:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2022, 11:17 PM

As the WMF-Legal project tag was added to this task, some general information to avoid wrong expectations:
Please note that public tasks in Wikimedia Phabricator are in general not a place where to expect feedback from the Legal Team of the Wikimedia Foundation due to the scope of the team and/or nature of legal topics. See the project tag description.
Please see https://meta.wikimedia.org/wiki/Legal for when and how to contact the Legal Team. Thanks!

Dzahn added a comment.Feb 17 2022, 11:18 PM

@Herald well, understood, but this is a an alert that Legal once requested to be notified on and it links to a Phabricator project called WMF-Legal ... so...

Dzahn added a project: Icinga.Feb 17 2022, 11:20 PM
Dzahn updated the task description. (Show Details)
Dzahn added subscribers: RhinosF1, AntiCompositeNumber, Slaporte, CRoslof.
Dzahn updated the task description. (Show Details)Feb 17 2022, 11:28 PM
JJMC89 added a subscriber: JJMC89.Feb 17 2022, 11:32 PM
Dzahn mentioned this in T119456: "ensure legal html" footer monitoring turned CRIT.Feb 17 2022, 11:34 PM

related tickets: T108081 T119456

Zabe added a subscriber: Zabe.Feb 17 2022, 11:58 PM
Peachey88 updated the task description. (Show Details)Feb 18 2022, 8:21 AM
Peachey88 added a subscriber: Peachey88.
Slaporte added a comment.Feb 18 2022, 6:29 PM

does it matter to you that the version changed to 3.0?

This change is not a problem. Thank you for flagging it.

do you still want this kind of monitoring and should we contact you if it happens again?

Yes, please do contact Legal if there are other changes. The ideal process would be an email to legal@wikimedia.org—if that's possible. If that's not possible, then tagging WMF-Legal is acceptable for now.

should we just adjust the monitoring so that from now on the new version is the expected one?

Yes please.

is it good or bad that it alerts on every version change in the future?

This kind of alert is still useful for any change on the footer. The links and text are legally significant, so it is valuable to have a step to verify that the required elements are present and accurate.

Dzahn claimed this task.Feb 18 2022, 7:07 PM
Dzahn changed the task status from Open to In Progress.Feb 18 2022, 7:18 PM
gerritbot added a comment.Feb 18 2022, 7:25 PM

Change 763810 had a related patch set uploaded (by Dzahn; author: Dzahn):

[operations/puppet@production] icinga: fix \"legal check\" monitoring footer HTML on en.wikipedia

https://gerrit.wikimedia.org/r/763810

gerritbot added a project: Patch-For-Review.Feb 18 2022, 7:25 PM
gerritbot added a comment.Feb 18 2022, 7:27 PM

Change 763810 merged by Dzahn:

[operations/puppet@production] icinga: fix \"legal check\" monitoring footer HTML on en.wikipedia

https://gerrit.wikimedia.org/r/763810

Dzahn closed this task as Resolved.Feb 18 2022, 7:45 PM
In T302045#7721945, @Slaporte wrote:

does it matter to you that the version changed to 3.0?

This change is not a problem. Thank you for flagging it.

ACK, it's just changing a label and not a link, I did not notice that in the original Icinga output at first. Thanks for confirming it's harmless.

do you still want this kind of monitoring and should we contact you if it happens again?

Yes, please do contact Legal if there are other changes. The ideal process would be an email to legal@wikimedia.org—if that's possible. If that's not possible, then tagging WMF-Legal is acceptable for now.

Ok, you got it! I am afraid the "not getting email anymore" part is a general Icinga question that I asked myself previously at T253733. Because I do remember we setup direct email to you guys with this in the past. It's a question for the observability team how we should handle the notification. I am going to ask but for now it's the Phabricator method I used here. Will let you know once something changes.

should we just adjust the monitoring so that from now on the new version is the expected one?

Yes please.

Ok, done! fixed in https://gerrit.wikimedia.org/r/c/operations/puppet/+/763810

19:33 <+icinga-wm> RECOVERY - Ensure legal html en.wp on en.wikipedia.org is OK: all html is present. https://phabricator.wikimedia.org/project/members/28/

is it good or bad that it alerts on every version change in the future?

This kind of alert is still useful for any change on the footer. The links and text are legally significant, so it is valuable to have a step to verify that the required elements are present and accurate.

Alright, cool. Won't change anything and point out to others working on monitoring this should stay around. Thanks for confirming and a very fast and effective response despite this being a Phabricator ping. It's appreciated.

Dzahn added a comment.Feb 18 2022, 7:46 PM

Screenshot from 2022-02-18 11-34-17.png (79×1 px, 21 KB)

Dzahn mentioned this in T253733: Icinga stopped sending emails.Feb 18 2022, 7:50 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 18 2022, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL