Maniphest T302049

class LoggedInUserMode does not implement setEnabled()
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	alex-mashin
	Feb 18 2022, 2:59 AM

Description

MW 1.35.3, PHP 7.4.27.

The class MobileFrontend\Features\LoggedInUserMode does not implement setEnabled() method declared in MobileFrontend\Features\IUserMode, which causes

[error] 1417#1417: *537 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Class MobileFrontend\Features\LoggedInUserMode contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (MobileFrontend\Features\IUserMode::setEnabled) in /var/www/wiki/w/extensions/MobileFrontend/includes/Features/LoggedInUserMode.php on line 20"

Event Timeline

alex-mashin created this task.Feb 18 2022, 2:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2022, 2:59 AM

alex-mashin added a comment.Feb 18 2022, 3:14 AM

This comment was removed by alex-mashin.

alex-mashin updated the task description. (Show Details)Feb 18 2022, 4:53 AM

What version of MobileFrontend are you using?

In IUserMode in 1.35, it doesn't have a setEnabled function - https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/REL1_35/includes/Features/IUserMode.php

Similarly, LoggedInUserMode has no abstract functions - https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/REL1_35/includes/Features/LoggedInUserMode.php

Neither does master...

In T302049#7720871, @Reedy wrote:

What version of MobileFrontend are you using?

I thought I was using REL1_35. Deleted the extension folder and cloned it again; the error disappeared. It seems I had messed it up with the IDE.

alex-mashin closed this task as Invalid.Feb 18 2022, 11:46 AM

class LoggedInUserMode does not implement setEnabled()Closed, InvalidPublicActions

Description

Event Timeline

class LoggedInUserMode does not implement setEnabled()
Closed, InvalidPublic
Actions