Page MenuHomePhabricator

Encourage review of recently translated articles with Section Translation
Closed, ResolvedPublic

Description

The initial implementation of T287236: Encourage review of recently translated articles only shows this entry point for articles created with Content Translation. This ticket proposes to adjust the entry point to show this entry point also on articles created with Section Translation. The rest of the rules should still apply.

This was not possible to implement initially since it depends on having persistency support for Section translation: T270499: Incorporate translated sections into the parallel corpora when published

Notice for recently translated articlesDialog with instructions to reviewSecondary tab of the dialog to expand
review-page.png (851×375 px, 133 KB)
review-edit.png (851×375 px, 107 KB)
review-add.png (851×375 px, 79 KB)

Event Timeline

Since the integration of section translations into parallel corpora, the section translations that create a new article (by translating the lead section) are also stored inside cx_translations table. This means that the recent translation entrypoint will work for section translations without any further effort from our side. Moving this ticket to "Needs QA".

After translating a section in an article and getting to the message "This page was recently translated" and then the "improve the translation" dialog, Are there supposed to be two sub headers where it reads "review contents" and then "Add new sections" ? as I don't see them as displayed in the picture below:

Screen Shot 2022-08-13 at 7.51.27 PM.png (826×426 px, 173 KB)

Also there is a UI bug I did observe, I will report this in another ticket ( in T315170)

@ngkountas can you please provide input to the last question? if its a defect I can move it back to inprogress

Awaiting input from DEV about the last comment. For now I will move this back to inprogress

@EChukwukere-WMF please note that as noted in the original ticket for this functionality (T287236)

The tab control will be only shown if there are sections available to translate. If there are not, the tab control will be hidden and only the instructions to review the contents will be provided.

So the reason that the two subheaders are missing is that there are not sections available to be translated for this article (at least according to cxserver). Additionally, the UI bug that you observed is already tracked in a different task (T314356) which is now in "Needs QA" column.

@ngkountas thanks for the clarification

Test status: QA PASS

see attached videoo

@ngkountas Also I did find something I think is an issue, when I click the "edit this page" button I get the display in the attached picture, I can open a defect ticket for it if you confirm it., it does look like a defect . I will still close this task though

Screen Shot 2022-08-23 at 10.14.55 PM.png (837×556 px, 231 KB)

see video

I will be moving this to done as the above named issued is reported in T316492

I was not able to find articles where this was working among the recently published ones. I created a follow-up ticket:
T316762: Invite to review of recently translated articles not showing when it should

it does seem to work for a newly translated page and does not account for data from recently published ones. We will look into it in T316762. Thanks