Maniphest T302082

"Read" menu item does not appear correctly on articles
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Feb 18 2022, 4:23 PM

Description

What is the problem?

On beta, the "Read" label does not appear in the menu item.

It happens on main and Talk page namespaces, but not user, user_talk or file (I didn't try any others).

This happens for Vector 2010 and 2022. The other skins don't have this (I don't think).

Steps to reproduce problem

Go to any article on beta, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.26780644845179213-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n

Environment

Browser: Firefox 91 and Chromium 87.
Wiki(s): https://en.wikipedia.beta.wmflabs.org 1.38.0-alpha (10755a3) 14:46, 18 February 2022. Vector 1.0.0 (08d2ae3) 07:42, 18 February 2022.

Details

	Subject	Repo	Branch	Lines +/-
	skins: Do not send null value to wfMessageFallback	mediawiki/core	master	+11 -2

Customize query in gerrit

Related Objects

Mentioned Here: T302051: MWException: Non-string key given
rSVEC08d2ae317148: Localisation updates from https://translatewiki.net.
rMW10755a3b7e13: Merge "Simplify ApiUserrights now that CentralAuth no longer extends it"

Event Timeline

dom_walden created this task.Feb 18 2022, 4:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2022, 4:23 PM

Ammarpad merged a task: T302097: "View" tab no longer has a label.Feb 18 2022, 8:30 PM

Ammarpad added subscribers: Esanders, Asartea, matmarex, Jdlrobson.

Per merged task priority

Change 763784 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] skins: Do not send null value to wfMessageFallback

https://gerrit.wikimedia.org/r/763784

gerritbot added a project: Patch-For-Review.Feb 18 2022, 9:06 PM

(Similar to T302051)

Change 763784 abandoned by Jdlrobson:

[mediawiki/core@master] skins: Do not send null value to wfMessageFallback

Reason:

Since it's Friday I'm reverting the original patch and I've folded these changes into https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763839 to give us more time to test.

https://gerrit.wikimedia.org/r/763784