Maniphest T302084

[Regression] Watchlist link appears twice in UI
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 18 2022, 4:28 PM

Description

The watchlist link should be hidden in the dropdown at large resolutions by being marked as a collapsible element.

Screen Shot 2022-02-18 at 8.24.20 AM.png (696×1 px, 149 KB)

A class is being added in user-links-collapsible-item but is never output to the page.

Seen on: https://en.wikipedia.org/wiki/Main_Page?safemode=1&useskin=vector-2022

TODO

Add a test that captures this issue
Fix

https://phabricator.wikimedia.org/

QA Results - Beta

AC	Status	Details
1	✅	T302084#7762544

QA Results - Prod

AC	Status	Details
1	✅	T302084#7772843

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	master	+58 -3	Ensure watchlist in user menu dropdown has the collapsible class

Customize query in gerrit

Related Objects

Mentioned In: T304039: Watchlist access key no longer working on new Vector
T289619: Move Watchlist button outside user menu dropdown

Event Timeline

Jdlrobson created this task.Feb 18 2022, 4:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2022, 4:28 PM

Jdlrobson mentioned this in T289619: Move Watchlist button outside user menu dropdown.Feb 18 2022, 4:28 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.Feb 18 2022, 4:48 PM

Jdlrobson updated the task description. (Show Details)

Huji updated the task description. (Show Details)Feb 18 2022, 5:23 PM

Od1n added a subscriber: Od1n.Feb 18 2022, 6:13 PM

ovasileva triaged this task as Medium priority.Feb 22 2022, 11:47 AM

Some people may prefer to keep this additional item in the dropdown menu:

Has a text description.
The "Contributions" link is next to it.

For example, personally:

I have much trouble with icon-only UI elements and much better identify text elements.
In my workflow I am used to middle-click links "Watchlist" and "Contributions" (the latter to review pages that have been modified after I edited them) at the same time.

LGoto moved this task from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.Mar 1 2022, 6:22 PM

LGoto set the point value for this task to 3.

bwang claimed this task.Mar 3 2022, 6:58 PM

bwang moved this task from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.

Change 767895 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure watchlist in user menu dropdown has the collapsible class, refactor user links methods in Hooks and add tests

https://gerrit.wikimedia.org/r/767895

gerritbot added a project: Patch-For-Review.Mar 3 2022, 9:26 PM

Tests currently fail because user-links-collapsible-item is added to the <li>, and mw-ui-icon mw-ui-icon-before are added to the inner <a>,
but the tests look at the same place for both sets of classes: $content['user-menu']['userpage']['class'].

Has been fixed on Gerrit (relevant occurrences of class replaced with link-class).

bwang removed bwang as the assignee of this task.Mar 7 2022, 6:02 PM

bwang moved this task from Doing to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.

bwang added a subscriber: bwang.

Jdlrobson claimed this task.Mar 7 2022, 6:39 PM

Change 767895 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure watchlist in user menu dropdown has the collapsible class

https://gerrit.wikimedia.org/r/767895

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2022, 12:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 8 2022, 1:00 AM

bwang reassigned this task from Jdlrobson to Edtadros.Mar 8 2022, 4:12 PM

bwang moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The watchlist link should be hidden in the dropdown at large resolutions by being marked as a collapsible element.

Screen Shot 2022-03-08 at 3.22.46 PM.png (388×404 px, 38 KB)

Edtadros updated the task description. (Show Details)Mar 8 2022, 11:24 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The watchlist link should be hidden in the dropdown at large resolutions by being marked as a collapsible element.

Screen Shot 2022-03-13 at 2.30.17 PM.png (407×318 px, 27 KB)

Screen Shot 2022-03-13 at 2.29.42 PM.png (366×420 px, 36 KB)

Edtadros updated the task description. (Show Details)Mar 13 2022, 9:31 PM

Looks good, resolving!

Tacsipacsi mentioned this in T304039: Watchlist access key no longer working on new Vector.Mar 17 2022, 1:52 AM

	F35004453: Screen Shot 2022-03-13 at 2.30.17 PM.png
	Mar 13 2022, 9:30 PM

	F35004454: Screen Shot 2022-03-13 at 2.29.42 PM.png
	Mar 13 2022, 9:30 PM

	F34990597: Screen Shot 2022-03-08 at 3.22.46 PM.png
	Mar 8 2022, 11:23 PM

	F34957020: Screen Shot 2022-02-18 at 8.24.20 AM.png
	Feb 18 2022, 4:28 PM

[Regression] Watchlist link appears twice in UIClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions

Description

TODO

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

[Regression] Watchlist link appears twice in UI
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions