Page MenuHomePhabricator

[Regression] Watchlist link appears twice in UI
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

The watchlist link should be hidden in the dropdown at large resolutions by being marked as a collapsible element.

Screen Shot 2022-02-18 at 8.24.20 AM.png (696×1 px, 149 KB)

A class is being added in user-links-collapsible-item but is never output to the page.

Seen on: https://en.wikipedia.org/wiki/Main_Page?safemode=1&useskin=vector-2022

TODO

  • Add a test that captures this issue
  • Fix

https://phabricator.wikimedia.org/

QA Results - Beta

ACStatusDetails
1T302084#7762544

QA Results - Prod

ACStatusDetails
1T302084#7772843

Event Timeline

ovasileva triaged this task as Medium priority.Feb 22 2022, 11:47 AM

Some people may prefer to keep this additional item in the dropdown menu:

  • Has a text description.
  • The "Contributions" link is next to it.

For example, personally:

  • I have much trouble with icon-only UI elements and much better identify text elements.
  • In my workflow I am used to middle-click links "Watchlist" and "Contributions" (the latter to review pages that have been modified after I edited them) at the same time.

Change 767895 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure watchlist in user menu dropdown has the collapsible class, refactor user links methods in Hooks and add tests

https://gerrit.wikimedia.org/r/767895

Tests currently fail because user-links-collapsible-item is added to the <li>, and mw-ui-icon mw-ui-icon-before are added to the inner <a>,
but the tests look at the same place for both sets of classes: $content['user-menu']['userpage']['class'].

Has been fixed on Gerrit (relevant occurrences of class replaced with link-class).

bwang removed bwang as the assignee of this task.Mar 7 2022, 6:02 PM
bwang added a subscriber: bwang.

Change 767895 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure watchlist in user menu dropdown has the collapsible class

https://gerrit.wikimedia.org/r/767895

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The watchlist link should be hidden in the dropdown at large resolutions by being marked as a collapsible element.

Screen Shot 2022-03-08 at 3.22.46 PM.png (388×404 px, 38 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The watchlist link should be hidden in the dropdown at large resolutions by being marked as a collapsible element.

Screen Shot 2022-03-13 at 2.30.17 PM.png (407×318 px, 27 KB)

Screen Shot 2022-03-13 at 2.29.42 PM.png (366×420 px, 36 KB)

Looks good, resolving!