Page MenuHomePhabricator

VisualEditor doesn’t suggest previous edit summaries (can't access property 1, result is null)
Closed, ResolvedPublicBUG REPORT

Description

On Wikimedia Commons, the VisualEditor feature to suggest previous edit summaries to me is no longer working. The console has the following error:

jQuery.Deferred exception: can't access property 1, result is null

Full stack trace with debug=2:

jQuery.Deferred exception: can't access property 1, result is null ve.ui.MWEditSummaryWidget.static.splitSummary@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwcore&skin=vector&version=ztntf:2584:3
ve.ui.MWEditSummaryWidget.prototype.getSummaries/this.getSummariesPromise</<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwcore&skin=vector&version=ztntf:2668:14
ve.ui.MWEditSummaryWidget.prototype.getSummaries/this.getSummariesPromise<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwcore&skin=vector&version=ztntf:2667:7
mightThrow@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3767:29
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3835:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3873:16
fire@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3501:31
fireWith@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3631:7
fire@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3639:10
fire@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3501:31
fireWith@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3631:7
Deferred/</deferred[tuple[0]]@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3969:36
ajax/xhr<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=mediawiki.api&skin=vector&version=ztntf:298:19
fire@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3501:31
fireWith@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:3631:7
done@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:9797:14
send/callback/<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:10058:17
EventHandlerNonNull*send@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:10077:18
ajax@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:9691:15
ajax@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=mediawiki.api&skin=vector&version=ztntf:270:12
get@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=mediawiki.api&skin=vector&version=ztntf:141:16
ve.ui.MWEditSummaryWidget.prototype.getSummaries@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwcore&skin=vector&version=ztntf:2651:60
ve.ui.MWEditSummaryWidget.prototype.getLookupRequest@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwcore&skin=vector&version=ztntf:2693:14
OO.ui.mixin.LookupElement.prototype.getRequest@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-widgets&skin=vector&version=ztntf:992:14
OO.ui.mixin.RequestManager.prototype.getRequestData@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-widgets&skin=vector&version=ztntf:533:43
OO.ui.mixin.LookupElement.prototype.getLookupMenuItems@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-widgets&skin=vector&version=ztntf:909:14
OO.ui.mixin.LookupElement.prototype.populateLookupMenu@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-widgets&skin=vector&version=ztntf:867:8
OO.ui.mixin.LookupElement.prototype.onLookupInputChange@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-widgets&skin=vector&version=ztntf:765:8
OO.EventEmitter.prototype.emit@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs&skin=vector&version=ztntf:902:12
OO.ui.InputWidget.prototype.setValue@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-core&skin=vector&version=ztntf:9754:8
OO.ui.InputWidget.prototype.onEdit/<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-core&skin=vector&version=ztntf:9705:11
setTimeout handler*OO.ui.InputWidget.prototype.onEdit@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-core&skin=vector&version=ztntf:9704:13
dispatch@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:5431:27
add/elemData.handle@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:5235:28
EventListener.handleEvent*add@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:5283:12
on/<@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:5183:16
each@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:386:19
each@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:208:17
on@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:5182:14
on@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=jquery&skin=vector&version=ztntf:5907:10
OoUiInputWidget@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-core&skin=vector&version=ztntf:9613:14
OoUiTextInputWidget@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-core&skin=vector&version=ztntf:11183:30
OoUiMultilineTextInputWidget@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-core&skin=vector&version=ztntf:11939:39
VeUiMWEditSummaryWidget@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwcore&skin=vector&version=ztntf:2545:34
ve.ui.MWSaveDialog.prototype.initialize@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=ext.visualEditor.mwsave&skin=vector&version=ztntf:616:26
OO.ui.Window.prototype.setManager@https://commons.wikimedia.org/w/load.php?debug=2&lang=en&modules=oojs-ui-windows&skin=vector&version=ztntf:2268:7

Permalink to the contributions API request (i.e. based on the request made by VisualEditor that I see in the network panel, but with ucstart added so the result doesn’t change when you open it later): https://commons.wikimedia.org/w/api.php?action=query&format=json&formatversion=2&list=usercontribs&ucuser=Lucas%20Werkmeister&ucprop=comment&uclimit=500&ucstart=2022-02-18T18%3A43%3A72.000Z

The reason for that is probably that one edit has a multi-line edit summary (I removed the ucprop so the result has more information):

$ curl -s 'https://commons.wikimedia.org/w/api.php?action=query&format=json&formatversion=2&list=usercontribs&ucuser=Lucas%20Werkmeister&uclimit=500&ucstart=2022-02-18T18%3A43%3A72.000Z' | jq '.query.usercontribs | .[] | select(.comment | contains("\n"))'
{
  "userid": 6198807,
  "user": "Lucas Werkmeister",
  "pageid": 113873782,
  "revid": 618057057,
  "parentid": 0,
  "ns": 6,
  "title": "File:Schoenberg - Drei Klavierstücke No. 1 - Irakly Avaliani.webm",
  "timestamp": "2021-12-31T23:55:35Z",
  "new": true,
  "minor": false,
  "top": false,
  "comment": "Uploaded a work by Composer: {{Creator|Wikidata=Q154770}}\nPerformer: {{Creator|Wikidata=Q110324829}} from https://www.youtube.com/watch?v=qZsy-rut9Ho with UploadWizard",
  "size": 575
}

See also the previous issue T277368.

Event Timeline

Change 763806 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/extensions/VisualEditor@master] MWEditSummaryWidget: Handle multi-line comments

https://gerrit.wikimedia.org/r/763806

Change 763806 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWEditSummaryWidget: Handle multi-line comments

https://gerrit.wikimedia.org/r/763806