Unbreak Resource loader
Closed, ResolvedPublic


Author: srobak

The Vector skin quit working this evening for me - no longer green on black - back to annoying & stock black on white. Haven't changed anything, verified all my settings. Noticed another user reported same problem in vector talk page on feb 18.

Version: unspecified
Severity: major

bzimport set Reference to bz28215.
bzimport created this task.Via LegacyMar 24 2011, 5:36 AM
TheDJ added a comment.Via ConduitMar 24 2011, 8:22 AM

Probably caused by one of these:

19:37 logmsgbot: catrope synchronized php-1.17/includes/resourceloader/ResourceLoader.php 'Bump filter cache version'
19:37 logmsgbot: catrope synchronized php-1.17/includes/libs/JavaScriptMinifier.php 'r84628'
18:34 logmsgbot: catrope synchronized php-1.17/includes/resourceloader/ResourceLoaderModule.php
18:34 logmsgbot: catrope synchronized php-1.17/includes/AutoLoader.php

Lupo added a comment.Via ConduitMar 24 2011, 8:52 AM

The resource loader doesn't load gadgets correctly anymore. At the English Wikipedia, NavigationPopups is suddenly missing its CSS, and HotCat isn't loaded at all.

See also http://en.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&diff=420455530&oldid=419941286 (Change in MediaWiki:Gadgets-definition to get HotCat to load again.)

Bawolff added a comment.Via ConduitMar 24 2011, 3:34 PM

In my local checkout of 1.17wmf1 - issue starts appearing at r84613.

Catrope added a comment.Via ConduitMar 24 2011, 3:46 PM

This should be fixed with r84683. It may take up to 5-10 minutes for the fix to propagate.

bzimport added a comment.Via ConduitMar 24 2011, 5:25 PM

srobak wrote:

Thanks all - seems to be working great :)

He7d3r added a comment.Via ConduitMar 25 2011, 1:51 AM

I wonder if this was the cause of the problem described on IRC on last month[1], when the extension refused loading a gadget marked with [ResourceLoader] even if its contents was just [2]:

var test = 'ok';

At that time it was necessary to remove[3] [ResourceLoader] from [[b:pt:MediaWiki:Gadgets-definition‎]], since the script wasn't being loaded at all.

After recent changes in the code (r84683 I believe) the script is loaded if the code [ResourceLoader] is added[4] to definition of the gadget.

Even if the issues were unrelated, thanks for fixing it! ;-)

[1] From [20:11:57] on: http://toolserver.org/~mwbot/logs/%23mediawiki/20110224.txt
[2] https://secure.wikimedia.org/wikibooks/pt/w/index.php/?diff=210918&oldid=210915
[3] https://secure.wikimedia.org/wikibooks/pt/w/index.php/?diff=next&oldid=210912
[4] https://secure.wikimedia.org/wikibooks/pt/w/index.php/?diff=216102&oldid=215401

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.