[M] MachineVision\Repository::getUnreviewedImageCountForUser has a suboptimal query loading more than 10,000 rows
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Feb 21 2022, 1:15 AM

Description

It is showing up in our list of bad queries and it seems it's doing something programmatically that can be easily done in the query itself. Group it by mvl_review and have it count(*).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Optimise getUnreviewedImageCountForUser	mediawiki/extensions/MachineVision	master	+14 -13

Customize query in gerrit

Event Timeline

Ladsgroup created this task.Feb 21 2022, 1:15 AM

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptFeb 21 2022, 1:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Umherirrender added a parent task: T301742: Increase log level of rowsAffected > 1000 on database writes in transaction profiler to warning or error.Feb 21 2022, 8:27 PM

Umherirrender removed a parent task: T301742: Increase log level of rowsAffected > 1000 on database writes in transaction profiler to warning or error.Feb 23 2022, 11:08 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Feb 28 2022, 5:28 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

Reedy added a project: Performance Issue.Feb 28 2022, 5:30 PM

CBogen renamed this task from MachineVision\Repository::getUnreviewedImageCountForUser has a suboptimal query loading more than 10,000 rows to [M] MachineVision\Repository::getUnreviewedImageCountForUser has a suboptimal query loading more than 10,000 rows.Mar 9 2022, 5:23 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Mar 9 2022, 5:42 PM

Seddon claimed this task.Mar 29 2022, 3:01 PM

Seddon moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Apr 11 2022, 2:43 PM

Seddon moved this task from Backlog to In development on the MachineVision board.Apr 11 2022, 4:03 PM

Change 801427 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MachineVision@master] Optimise getUnreviewedImageCountForUser

https://gerrit.wikimedia.org/r/801427

gerritbot added a project: Patch-For-Review.May 30 2022, 8:21 PM

Seddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.May 30 2022, 8:40 PM

Seddon moved this task from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.Jun 27 2022, 1:29 AM

Seddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jul 20 2022, 10:54 AM

Change 801427 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Optimise getUnreviewedImageCountForUser

https://gerrit.wikimedia.org/r/801427

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 6 2022, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2022, 9:31 AM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Sep 7 2022, 12:32 PM

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Sep 9 2022, 12:46 AM

Checked in logstash for wmf.2 - the dashboard Slow queries mediawiki database doesn't list the reported query.

[M] MachineVision\Repository::getUnreviewedImageCountForUser has a suboptimal query loading more than 10,000 rowsClosed, ResolvedPublicActions

Description

Details

Event Timeline

[M] MachineVision\Repository::getUnreviewedImageCountForUser has a suboptimal query loading more than 10,000 rows
Closed, ResolvedPublic
Actions