Page MenuHomePhabricator

Merges in mediawiki/core failing with "KeyError: 'server'"
Closed, ResolvedPublic

Description

All merges in mediawiki/core are failing with KeyError: 'server' error in the mediawiki-quibble-vendor-sqlite-php72-docker job.

Examples:

  1. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763721https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-sqlite-php72-docker/13488/console
  2. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/747229https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-sqlite-php72-docker/13484/console
  3. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763937https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-sqlite-php72-docker/13480/console
00:00:25.410 INFO:quibble.commands:>>> Start: Run Post-dependency install, pre-database dependent steps in parallel (concurrency=3):
00:00:25.410 * PHPUnit unit tests
00:00:25.410 * Install MediaWiki, db=<quibble.backend.SQLite object at 0x7f7020a1f908> vendor=True
00:00:25.410 * npm install in /workspace/src
00:00:25.532 INFO:quibble.commands:<<< Finish: Run Post-dependency install, pre-database dependent steps in parallel (concurrency=3):
00:00:25.532 * PHPUnit unit tests
00:00:25.532 * Install MediaWiki, db=<quibble.backend.SQLite object at 0x7f7020a1f908> vendor=True
00:00:25.532 * npm install in /workspace/src, in 0.122 s
00:00:25.538 Traceback (most recent call last):
00:00:25.538   File "/usr/local/bin/quibble", line 10, in <module>
00:00:25.538     sys.exit(main())
00:00:25.538   File "/usr/local/lib/python3.7/dist-packages/quibble/cmd.py", line 783, in main
00:00:25.538     cmd.execute(plan, dry_run=args.dry_run)
00:00:25.538   File "/usr/local/lib/python3.7/dist-packages/quibble/cmd.py", line 512, in execute
00:00:25.538     quibble.commands.execute_command(command)
00:00:25.538   File "/usr/local/lib/python3.7/dist-packages/quibble/commands.py", line 26, in execute_command
00:00:25.538     command.execute()
00:00:25.538   File "/usr/local/lib/python3.7/dist-packages/quibble/commands.py", line 1000, in execute
00:00:25.538     for error, capture in results_in_progress:
00:00:25.538   File "/usr/local/lib/python3.7/dist-packages/quibble/util.py", line 143, in __iter__
00:00:25.538     for obj in self.iterable:
00:00:25.538   File "/usr/lib/python3.7/multiprocessing/pool.py", line 748, in next
00:00:25.538     raise value
00:00:25.538   File "/usr/lib/python3.7/multiprocessing/pool.py", line 431, in _handle_tasks
00:00:25.538     put(task)
00:00:25.538   File "/usr/lib/python3.7/multiprocessing/connection.py", line 206, in send
00:00:25.538     self._send_bytes(_ForkingPickler.dumps(obj))
00:00:25.538   File "/usr/lib/python3.7/multiprocessing/reduction.py", line 51, in dumps
00:00:25.538     cls(buf, protocol).dump(obj)
00:00:25.538   File "/usr/local/lib/python3.7/dist-packages/quibble/backend.py", line 139, in __getstate__
00:00:25.538     del state["server"]
00:00:25.538 KeyError: 'server'
00:00:25.875 Build step 'Execute shell' marked build as failure

Event Timeline

matmarex triaged this task as Unbreak Now! priority.Feb 21 2022, 2:36 PM
matmarex updated the task description. (Show Details)

Change 763979 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Revert \"jjb: update Quibble jobs from 1.3.0 to 1.4.0\"

https://gerrit.wikimedia.org/r/763979

Mentioned in SAL (#wikimedia-releng) [2022-02-21T14:58:37Z] <hashar> Reverting Quibble jobs from 1.4.0 to 1.3.0 # T302226

hashar added subscribers: awight, kostajh, hashar.

Looks like something is off with Quibble 1.4.0 when running some tasks in parallel :-\

Change 763979 merged by jenkins-bot:

[integration/config@master] Revert \"jjb: update Quibble jobs from 1.3.0 to 1.4.0\"

https://gerrit.wikimedia.org/r/763979

hashar lowered the priority of this task from Unbreak Now! to High.Feb 21 2022, 3:47 PM

I have rolled back the jobs. We will find out how to fix it in Quibble

Change 764419 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] backend: Check if key exists before deleting

https://gerrit.wikimedia.org/r/764419

Change 764420 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] jjb: Add quibble-fullrun-sqlite job

https://gerrit.wikimedia.org/r/764420

Change 764420 merged by jenkins-bot:

[integration/config@master] jjb: Add quibble-fullrun-sqlite job

https://gerrit.wikimedia.org/r/764420

Change 764419 merged by jenkins-bot:

[integration/quibble@master] backend: Check if key exists before deleting

https://gerrit.wikimedia.org/r/764419

Change 767706 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] release: Quibble 1.4.2

https://gerrit.wikimedia.org/r/767706

Change 767706 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.4.2

https://gerrit.wikimedia.org/r/767706

Change 767749 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Quibble jobs from 1.3.0 to 1.4.3

https://gerrit.wikimedia.org/r/767749

Change 767749 merged by jenkins-bot:

[integration/config@master] jjb: update Quibble jobs from 1.3.0 to 1.4.3

https://gerrit.wikimedia.org/r/767749