🟩 Create a configuration setting to enable wikibase REST API
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Silvan_WMDE
	Feb 22 2022, 2:50 PM

Description

enable the REST endpoints if setting is true OR disable the REST endpoints if setting is false

* find or create a test system to enable this setting on test system decision was deferred

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Wikibase	master	+130 -0	REST: add feature toggle to use with route handler
mediawiki/extensions/Wikibase	master	+44 -0	REST: add example feature toggled route handler
mediawiki/extensions/Wikibase	master	+18 -0	REST: Add feature toggle setting for REST API

Customize query in gerrit

Event Timeline

Silvan_WMDE created this task.Feb 22 2022, 2:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2022, 2:50 PM

Silvan_WMDE updated the task description. (Show Details)Feb 22 2022, 2:54 PM

Silvan_WMDE set the point value for this task to 3.

WMDE-leszek added a subscriber: WMDE-leszek.Feb 22 2022, 3:00 PM

Silvan_WMDE renamed this task from Create a configuration setting to enable wikibase REST API to 🟩 Create a configuration setting to enable wikibase REST API.Feb 23 2022, 8:42 AM

Silvan_WMDE added a project: Story.

Jakob_WMDE claimed this task.Feb 28 2022, 10:31 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 1) board.

I cannot find any hook to dynamically (un)register REST API routes. As an alternative I could imagine a decorator that wraps all our route handlers in the factory method and returns a 4xx (403? 404?) on execute (or checkPreconditions?) if the REST API setting isn't enabled.

Change 766621 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: add feature toggle setting for REST API

https://gerrit.wikimedia.org/r/766621

gerritbot added a project: Patch-For-Review.Feb 28 2022, 1:23 PM

Change 766778 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: add route handler to use with feature toggle

https://gerrit.wikimedia.org/r/766778

Change 766811 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: add example route handler for feature toggle

https://gerrit.wikimedia.org/r/766811

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 1) board.Mar 1 2022, 11:25 AM

Jakob_WMDE updated the task description. (Show Details)Mar 1 2022, 1:37 PM

Change 766621 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add feature toggle setting for REST API

https://gerrit.wikimedia.org/r/766621

Change 766778 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: add feature toggle to use with route handler

https://gerrit.wikimedia.org/r/766778

Change 766811 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: add example feature toggled route handler

https://gerrit.wikimedia.org/r/766811

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 1 2022, 3:00 PM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 1) board.Mar 2 2022, 8:50 AM

Jakob_WMDE moved this task from Done to Test (Verification) on the Wikibase Product Platform (v1) (Sprint 1) board.

Tested and confirmed it works as intended. Thanks!

WMDE-leszek moved this task from Test (Verification) to Done on the Wikibase Product Platform (v1) (Sprint 1) board.Mar 3 2022, 7:47 AM

WMDE-leszek closed this task as Resolved.Mar 11 2022, 3:50 PM

🟩 Create a configuration setting to enable wikibase REST APIClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Event Timeline

🟩 Create a configuration setting to enable wikibase REST API
Closed, ResolvedPublic3 Estimated Story Points
Actions