Page MenuHomePhabricator

Reply tool fails on some pages with audio
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • The reply tool link becomes disabled, as to all other reply to links on the page.

What should have happened instead?:

  • The reply to input box should open an accept input.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Reloading the page resets the status, and makes other reply tool links work on that page, but not the offending one.

Console error reports:
jQuery.Deferred exception: can't access property "ownerDocument", sibs[0] is undefined

Similiar to report in T301427 , though this is failing even without the Beta "new video player" being enabled.

Event Timeline

matmarex added a subscriber: matmarex.

I think the patch from T301427 fixes this case as well.

Change 762525 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Don't insert comment markers inside replaced elements (like `<video>`)

https://gerrit.wikimedia.org/r/762525

matmarex renamed this task from Reply tool fails on some pages with videos to Reply tool fails on some pages with audio.Feb 22 2022, 3:11 PM
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

Change 762525 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't insert comment markers inside replaced elements (like `<video>`)

https://gerrit.wikimedia.org/r/762525

This should be good now.

Screenshot 2022-03-01 at 00.46.05.png (1×2 px, 848 KB)

The [reply] links across the page work as expected. Console looks clear as well.