Page MenuHomePhabricator

Language files are not XHTML-compliant.
Closed, ResolvedPublic

Description

Author: zigger

Description:
(split out from bug 1021)

The language files have a mixture of <br>, <br/>, and <br />. The final form is
the preferred one for XHTML conformance.

They also have a mixture of wiki mark-up and HTML mark-up:

<strong>text</strong>, <b>text</b>, '''text''',
<em>text</em>, <i>text</i>, ''text''

Assuming that all messages are parsed, the final form is the preferred one.


Version: unspecified
Severity: normal

Details

Reference
bz1023

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:02 PM
bzimport set Reference to bz1023.
bzimport added a subscriber: Unknown Object (MLST).

zigger wrote:

Issues are in REL1_3, REL1_4 and HEAD.

wikipedia wrote:

I've made the change of <br> and <br/> to <br /> in 1.4 and HEAD (I didn't see
the point in bothering for 1.3, as checking this in takes forever over my poor
DSL uplink, and 1.4 will be current real soon now). I did this using sed and
then checking the results look reasonable. Hopefully doing this in an automated
manner is less error prone than doing it manually.

As for the <strong> and <em> stuff, I'm not 100% sure what text ends up going
through the parser, and I don't have time to check right now, so I left that
alone. If someone knows or wants to work it out, feel free to make the necessary
changes.

jeluf wrote:

Changing to "enhancement", since <em> versus '' is a stylistic issue and not a bug.

zigger wrote:

Other XHTML issues in the 'googlesearch' message for most languages in most
branches:
upper case elements and attributes,
various attribute values are not quoted, and
missing " />" closer in "img" and "input" tags.

I've split out the markup inconsistency that's not XHTML-related to a new low
priority enhancement request. See bug 1037

zigger wrote:

Sorry, the above comments about 'googlesearch' are probably a duplicate of bug 210

robchur wrote:

I'd suggest passing all interface messages through the parser and ditching HTML
in them, myself. I would have thought we parsed most of them anyway, and don't
the tidy functions pick up stuff like <br> and <br/> ?

jimmy.collins wrote:

cleanup br-tags (patch for trunk, r14420)

Here is a patch that replaces <br/>-tags to <br />-tags in some
MessagesXx.php-files (XHTML compliant)

attachment xhtml-br_bug1023.patch ignored as obsolete

jimmy.collins wrote:

cleanup one br-tag in SpecialEmailuser.php (trunk, r14420)

Also found one <br>-tag in SpecialEmailuser.php

attachment SpecialEmailuser.php.bug1023.patch ignored as obsolete

jimmy.collins wrote:

cleanup br-tags (patch for trunk)

Here is another patch that replaces <br/>-tags to <br />-tags in MessagesSq.php
(XHTML compliant)

attachment xhtml-br_bug1023.patch ignored as obsolete

jimmy.collins wrote:

(In reply to comment #10)

Here is another patch that replaces <br/>-tags to <br />-tags in MessagesSq.php
(XHTML compliant)

<br> --> <br />

jimmy.collins wrote:

cleanup br-tags in SpecialRecentchanges.php and SpecialPreferences.php

attachment Specialxx.php.bug1023.patch ignored as obsolete

jimmy.collins wrote:

cleanup br-tags (patch for trunk)

Here is another patch that replaces <br>-tags to <br />-tags (XHTML compliant)
in:
MessagesSq.php

attachment xhtml-br_bug1023.patch ignored as obsolete

jimmy.collins wrote:

(In reply to comment #13)

Created an attachment (id=1970) [edit]
cleanup br-tags (patch for trunk)

Here is another patch that replaces <br>-tags to <br />-tags (XHTML compliant)
in:

  • MessagesYi.php
  • MessagesSk.php
  • MessagesNl.php
  • MessagesLa.php

jimmy.collins wrote:

Comment on attachment 1842
cleanup one br-tag in SpecialEmailuser.php (trunk, r14420)

already applied

jimmy.collins wrote:

cleanup br-tags (patch for trunk)

The patch replaces <br>-tags to <br />-tags (XHTML compliant) in:

  • languages/MessagesYi.php
  • languages/MessagesSk.php
  • languages/MessagesNl.php
  • languages/MessagesLa.php
  • languages/MessagesGsw.php

attachment xhtml-br_bug1023.patch ignored as obsolete

robchur wrote:

Applied to SVN trunk, r15022.

jimmy.collins wrote:

cleanup br-tags (not i18n), patch for trunk

The patch updates following files:

  • math/texvc_cgi.ml
  • config/index.php
  • includes/SpecialRecentchanges.php
  • includes/SpecialPreferences.php

attachment Specialxx.php.bug1023.patch ignored as obsolete

jimmy.collins wrote:

fix for hr- and br-tags in i18n (xhtml), patch for trunk

The attached patch fixes some br- and hr-tags in several language files
(MessagesXx.php)

attachment i18n_xhtml.patch ignored as obsolete

jimmy.collins wrote:

(In reply to comment #18)
applied to SVN trunk, r15243

jimmy.collins wrote:

(In reply to comment #19)
applied to SVN trunk, r15245

Comment on attachment 2006
cleanup br-tags (not i18n), patch for trunk

r15243

Comment on attachment 2037
fix for hr- and br-tags in i18n (xhtml), patch for trunk

r15245

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:21 AM
epriestley added a commit: Unknown Object (Diffusion Commit).