"Legacy hint" link doesn't work on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Feb 22 2022, 3:31 PM

Description

The link in this box does not take you to the right place on mobile:

Testing instructions

Visit a test wiki with mobile DT enabled, e.g. https://simple.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page
Paste the following into the dev console (F12):
- mw.config.set('wgUserEditCount', 501); mw.user.options.set('discussiontools-newtopictool-opened', false);
Click "Add topic" at the top of the page

Details

	Subject	Repo	Branch	Lines +/-
	Fix legacy hint URI on mobile	mediawiki/extensions/DiscussionTools	master	+12 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	None	T278588 Mobile talk page improvements
Resolved	• ppelberg	T282638 [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis
Open	None	T233446 [Epic] New Discussion Tool
Open	None	T308390 Avoid direct link to edit non-existing talk pages in Minerva
Duplicate	None	T270537 Introduce New Discussion Tool on mobile
Resolved	• ppelberg	T287805 Introduce talk page empty state experiences on mobile
Resolved	Esanders	T302307 "Legacy hint" link doesn't work on mobile

Event Timeline

Esanders created this task.Feb 22 2022, 3:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2022, 3:31 PM

Change 764804 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Fix legacy hint URI on mobile

https://gerrit.wikimedia.org/r/764804

gerritbot added a project: Patch-For-Review.Feb 22 2022, 3:31 PM

Esanders claimed this task.Feb 22 2022, 3:32 PM

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

I think it'd also be reasonable to not give a legacy link on mobile, honestly... but it's a quick fix.

Change 764804 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix legacy hint URI on mobile

https://gerrit.wikimedia.org/r/764804

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2022, 4:10 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 22 2022, 5:00 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Feb 24 2022, 4:06 PM

What are the steps to reproduce this?

What I am trying isn't working. It's either I am reproducing it wrong or I am testing on the wrong wikis.

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Mar 12 2022, 2:30 AM

Visit a test wiki with mobile DT enabled, e.g. https://simple.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page
Paste the following into the dev console (F12):
- mw.config.set('wgUserEditCount', 501); mw.user.options.set('discussiontools-newtopictool-opened', false);
Click "Add topic" at the top of the page

Esanders updated the task description. (Show Details)Mar 13 2022, 4:02 PM

In T302307#7771953, @Esanders wrote:

Visit a test wiki with mobile DT enabled, e.g. https://simple.m.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page

Paste the following into the dev console (F12):

mw.config.set('wgUserEditCount', 501); mw.user.options.set('discussiontools-newtopictool-opened', false);

Click "Add topic" at the top of the page