Page MenuHomePhabricator

Suggested edits: show the full task feed on post-edit dialog
Closed, ResolvedPublic


In T272664: Add a link: refresh button on post-edit dialog (nice to have), we implemented the refresh button on the post-edit dialog, which allows users to cycle through "next suggestion" options. We now want to replace it with arrows that allow users to navigate back and forth through their feed, giving them more granularity of choices. There are two reasons we want to replace it with arrows:

  • It gives the users the same amount of flexibility they're used to from the suggested edits module.
  • In our funnel analysis data, we saw that only 2-3% of users use the refresh button after their first edit. We want to see if a different interaction is found to be more valuable by the users.

Proposed design from related task T301603:

image.png (2×2 px, 630 KB)

Implementation notes

Currently the task feed is part of SuggestedEditsModule class, which handles both the state management (task queue, which task the user is viewing, which filters are selected etc) and the presentation (showing the task card, showing navigation buttons). The state management and the presentation should be separated so that the task feed can be shown from other modules with a different presentation.

Rough summary of changes

(to be done once the patches for T301603: Newcomer tasks: increased flexibility at post-edit dialog and T303985: Suggested edits: make task feed reusable are merged)

In PostEdit/index.js

  • Remove GrowthTaskApi and its dependencies (also from extension.json)
  • Replace the task queue (otherTasks) with value from NewcomerTasksStore
  • In NewcomerTasksStore, the task the user just finished needs to be filtered out of the queue
  • Remove nextTaskIndex — use getter to retrieve the current value from NewcomerTasksStore
  • In navigateTask, call showNextTask/showPreviousTask rather than updating the local states
  • Remove fetchOtherTasks, use NewcomerTasksStore.fetchTasks instead
  • In setup, remove logic to fetch extra data (this should be handled automatically by NewcomerTasksStore)
  • Set up event handlers to update PostEditPanel when the task queue changes and when extra data is updated for the current task

Event Timeline

@RHo -- this is with you now for designs on both desktop and mobile.

mewoph renamed this task from Suggested edits: navigation arrows on post-edit dialog to Suggested edits: show the full task feed on post-edit dialog.Mar 7 2022, 8:56 PM
mewoph updated the task description. (Show Details)
kostajh lowered the priority of this task from High to Medium.Mar 14 2022, 8:11 PM

Change 786403 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] [DNM] Post-edit dialog: show the full task feed

With latest changes:

Desktop (only copyedit selected)

postedit_taskfeed.gif (548×960 px, 651 KB)

Mobile (add link and add image selected)

postedit_multipletypes.gif (512×702 px, 301 KB)

Change 786403 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post-edit dialog: show the full task feed

For @RHo quick review - I did not see any issues in production (testwiki wmf.12) Below are just two additional cases to the screenshots in @mewoph's comment above (

  • an image was rejected
  • only one recommendation left in the feed

Screen Shot 2022-05-19 at 9.49.21 AM.png (1×1 px, 239 KB)


  • no recommendations left in the feed

Screen Shot 2022-05-19 at 9.50.26 AM.png (782×1 px, 145 KB)

LGTM, thank you!