Page MenuHomePhabricator
Create Task
Maniphest T302370

🟪 Create a response body for retrieving a single item
Closed, ResolvedPublic
Actions

Description

  • use the following existing classes and services to get information for the body:
    • Itemto be retrieved by the data access service
    • WikibaseRepo.EntityLookup to retrieve the item
    • ItemSerializer to create an array that is included in the DTO returned by the usecase (which is not the response itself...)
  • create a response with a body

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Use GetItem use case in RouteHandlermediawiki/extensions/Wikibasemaster+60 -14
REST: Add first integration test for GetItemmediawiki/extensions/Wikibasemaster+114 -1
REST: Add custom ItemSerializermediawiki/extensions/Wikibasemaster+79 -3
REST: Rename GetItemResponse to GetItemResultmediawiki/extensions/Wikibasemaster+9 -8
REST: First getItem happy pathmediawiki/extensions/Wikibasemaster+90 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.Feb 23 2022, 8:33 AM
Silvan_WMDE mentioned this in T302054: 🟪 Create a simple implementation of GET /entities/items/{item_id}.
Silvan_WMDE removed a project: Story.Feb 23 2022, 8:37 AM
gerritbot added a comment.Feb 23 2022, 4:31 PM

Change 765306 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: First getItem happy path

https://gerrit.wikimedia.org/r/765306

gerritbot added a project: Patch-For-Review.Feb 23 2022, 4:31 PM
gerritbot added a comment.Feb 24 2022, 9:51 AM

Change 765306 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: First getItem happy path

https://gerrit.wikimedia.org/r/765306

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 24 2022, 10:00 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 1) board.Feb 24 2022, 10:03 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 24 2022, 10:10 AM
gerritbot added a comment.Feb 25 2022, 4:35 PM

Change 766151 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Rename GetItemResponse to GetItemResult

https://gerrit.wikimedia.org/r/766151

gerritbot added a project: Patch-For-Review.Feb 25 2022, 4:35 PM

Change 766152 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Add ItemSerializer to rename claims to statments

https://gerrit.wikimedia.org/r/766152

gerritbot added a comment.Feb 25 2022, 4:35 PM

Change 766153 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Add first integration test for GetItem

https://gerrit.wikimedia.org/r/766153

gerritbot added a comment.Mar 1 2022, 2:06 PM

Change 766151 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename GetItemResponse to GetItemResult

https://gerrit.wikimedia.org/r/766151

gerritbot added a comment.Mar 1 2022, 2:29 PM

Change 766152 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add custom ItemSerializer

https://gerrit.wikimedia.org/r/766152

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 1 2022, 3:00 PM
gerritbot added a comment.Mar 1 2022, 3:28 PM

Change 767198 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Use GetItem use case in RouteHandler

https://gerrit.wikimedia.org/r/767198

gerritbot added a comment.Mar 1 2022, 4:28 PM

Change 766153 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add first integration test for GetItem

https://gerrit.wikimedia.org/r/766153

Jakob_WMDE mentioned this in T302313: 🟪 Set up contract/schema test for GET /entities/items/{item_id}.Mar 2 2022, 8:58 AM
gerritbot added a comment.Mar 2 2022, 10:41 AM

Change 767198 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use GetItem use case in RouteHandler

https://gerrit.wikimedia.org/r/767198

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2022, 11:11 AM
Silvan_WMDE moved this task from Doing to Test (Verification) on the Wikibase Product Platform (v1) (Sprint 1) board.Mar 2 2022, 12:18 PM
Jakob_WMDE moved this task from Test (Verification) to Done on the Wikibase Product Platform (v1) (Sprint 1) board.Mar 3 2022, 8:56 AM
WMDE-leszek closed this task as Resolved.Mar 31 2022, 12:31 PM
WMDE-leszek claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits