| Msz2001 | |
| Feb 23 2022, 11:47 AM |
| F34982497: main_page.jpeg | |
| Mar 7 2022, 5:00 PM |
| F34982472: AndroidDisplay.jpeg | |
| Mar 7 2022, 5:00 PM |
| F34982476: IMG_2EB9EBC8F3CB-1.jpeg | |
| Mar 7 2022, 5:00 PM |
| F34982496: discussion_page.jpeg | |
| Mar 7 2022, 5:00 PM |
| F34962970: E8EB1028-7F6F-49F0-B14A-9F4D7C73D388.png | |
| Feb 23 2022, 12:10 PM |
| F34962971: 429717CB-104A-4238-9568-24CCEE1BAE46.png | |
| Feb 23 2022, 12:10 PM |
| F34962955: image.png | |
| Feb 23 2022, 11:55 AM |
Today the Discussion Tools arrived on plwiki (and perhaps other wikis). It uses the same layout as on the desktop to display the [subscribe] and [cancel subscription] buttons. However, this makes headers very narrow as button takes around 50% of the screen width. What's more it's a button on a button, since by default headers on mobile are clickable.
A screenshot is available here: https://imgur.com/a/JS7HNNX
https://pl.m.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne
Oh no, the mobile version of DiscussionTools isn't supposed to be enabled yet, and the [subscribe] links aren't supposed to show even if it's enabled.
This is some mistake related to the experimental deployment on ht.wp (T302259).
Change 765248 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix check for enabling features on mobile
@matmarex is this bug possible related? There shouldn’t be a „new topic“ discussion button at the main page and there should only one button at discussion pages
Both of these problems only affect users who had the DiscussionTools beta feature enabled (in desktop preferences).
For our actual plan to roll out topic subscriptions and other DiscussionTools features on mobile, see:
I will deploy the fix for this in the next available window, in about 2 hours: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20220223T1400 (either the proposed patch above if I can find a colleague to review it, or a revert of the earlier coniguration change that caused this if I can't).
Change 765248 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix check for enabling features on mobile
Change 765211 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.22] Fix check for enabling features on mobile
Change 765212 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.23] Fix check for enabling features on mobile
Change 765211 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.22] Fix check for enabling features on mobile
Change 765212 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.23] Fix check for enabling features on mobile
Mentioned in SAL (#wikimedia-operations) [2022-02-23T14:10:07Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.22/extensions/DiscussionTools/includes/Hooks/HookUtils.php: 815b3d1: Fix check for enabling features on mobile (T302388) (duration: 00m 50s)
Mentioned in SAL (#wikimedia-operations) [2022-02-23T14:11:20Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/extensions/DiscussionTools/includes/Hooks/HookUtils.php: 78f0d9d: Fix check for enabling features on mobile (T302388) (duration: 00m 49s)
