As discussed in our meeting, here’s the view with German labels in the toolbar @JTannerWMF

@Sharvaniharan APK? Thanks!

@scblr sorry...
https://github.com/wikimedia/apps-android-wikipedia/pull/3174/checks

Great work @Sharvaniharan — this was quick! 👏

01) Please use the same color for the icon and 'More' label as in the rest of the toolbar (grey)

02) It seems like the space in the toolbar is not evenly distributed, which results in a smaller tap target for the 'More' item. It’s better visible in landscape mode, see the second image. Can you distribute it evenly so we have a bigger tap target size for 'More' ?

03) Bug: Enabling 'Reading focus mode' leads to this 👇

F35009770}

04) Please make sure that the entire row is a tap target for these list items

05) Please change the navbar to white to connect it better with the bottom sheet in both instances of the component (main nav and article toolbar)

Implementation	vs	Design

06) Label and icon colors differ from the 'More' menu in the main nav:

Main nav	vs	Article toolbar

Please use color_group_5 for the labels and color_group_8 for the icons in both instances of the component (main nav and article toolbar)

07) Please use Roboto Medium for the labels in both instances of the component (main nav and article toolbar)

Hey @Sharvaniharan – per discussion in our call today, here are the two variants we would like to test:

And here’s the link to Figma:

https://www.figma.com/file/kmcTXhmwkHNDgOyoCHbWKz/?node-id=641%3A7946

Thanks for working on this!

Hi @scblr ,

Please review variant 'B' here : https://github.com/wikimedia/apps-android-wikipedia/pull/3229/checks
It is ready for design review.

Thank you :)

Hi @scblr
I have fixed the issues... Please take a look and let me know your thoughts ! :)

A few things:

1. Some translations were already available in our app, and were different from the ones you provided in the excel. It is possible they might just be 2 different ways of translating, but just wanted to confirm which version you would like to keep.
2. Tooltip for customize toolbar is only shown after watchlist as of now, do you want me to show customize toolbar tooltip without any restriction?
3. I did not make the order change of the bottom toolbar shortcuts in version 'B'. Just wanted to make sure... we want to also think about whether or not the 'contents' button being changed in position is having an effect on the usage. So do you want to leave the old order in version B? If not, it is a very small fix i can do it quickly tomorrow.

Var A APK: https://github.com/wikimedia/apps-android-wikipedia/pull/3231/checks
Var B APK: https://github.com/wikimedia/apps-android-wikipedia/pull/3229/checks

Thank you!

This is great so far @Sharvaniharan, answers to your questions below (+ some other things I noticed).

01)

Some translations were already available in our app, and were different from the ones you provided in the excel. It is possible they might just be 2 different ways of translating, but just wanted to confirm which version you would like to keep.

Both variants: If we have all translations in the languages we are testing in (AR, FR, HI, JA, ID), we can keep the existing one from translatewiki.

02)

Tooltip for customize toolbar is only shown after watchlist as of now, do you want me to show customize toolbar tooltip without any restriction?

Both variants: Hmm, I have not seen the watchlist tooltip in both variants on my device? But to make sure, let’s remove the article Watchlist tooltip from both variants, ok?

03)

I did not make the order change of the bottom toolbar shortcuts in version 'B'. Just wanted to make sure... we want to also think about whether or not the 'contents' button being changed in position is having an effect on the usage. So do you want to leave the old order in version B? If not, it is a very small fix i can do it quickly tomorrow.

Both variants: Thanks for checking on this. The TOC button should be positioned at the left side, to avoid variables in the test:

Variant A: TOC, Save, Find in article, Theme, More

Variant B: TOC, Save, Find in article, Theme, Language

As the new version of Desktop Wikipedia and the iOS app feature the TOC on the left side, we are aiming to make it the default as well.

04) Both variants: The tooltip should only go away if users deliberately tap 'GOT IT' (not on scroll or tapping anywhere else on the screen)

05) Both variants: Use the exact same style and icon for the 'CUSTOMIZE TOOLBAR' label as for other items in the list (color, font style)

	A	B
Implementation
Design

06) Variant A: The tooltip sits too high above the actual 'More' button, can we move it closer to the button?

Implementation	Design

07) Variant A: Android’s status bar disappears when enabling the bottom sheet? Please make sure to display it:

08) Variant B: The customize toolbar tooltip points to the wrong place:

09) Variant B: Copy on the details screen is outdated. Update it to Customize the bottom toolbar with 5 shortcuts you find most helpful. (per translation Gsheet)

Hi @scblr
Thank you for the review!
Sorry some of the changes were not reflecting on var B because of some build issue. I have fixed that and also the ither issues mentioned here.. Please take a look and lmk.

@ things that are not fixed:

1. The gap between tooltip and more button. This could be the library short-coming. I am still trying to check it. Hopefully is it not a blocker? [ point 06 above]
2. 07) the status bar disappearing is an unavoidable issue. We can only do one of two things when a bottomsheet opens. Either we can leave it to default behavior like the explore more bottom, where you can see system nav bar below and status bar above.

And is we hide, it will be like the theme bottomsheet currently. Both system related bars get hidden

Thanks @Sharvaniharan , we are almost ready for the tests! 😍

A few questions below:

01)

The gap between tooltip and more button. This could be the library short-coming. I am still trying to check it. Hopefully is it not a blocker? [ point 06 above]

Are you sure about this? It does not seem to have been an issue in the past?

Watchlist tooltip	Toolbar tooltip

That said, it is not a blocker.

02)

the status bar disappearing is an unavoidable issue. We can only do one of two things when a bottomsheet opens. Either we can leave it to default behavior like the explore more bottom, where you can see system nav bar below and status bar above.

Okay! So let’s keep it as is then in both variants (disappearing status bar)

03)

Variant B: Copy on the details screen is outdated. Update it to Customize the bottom toolbar with 5 shortcuts you find most helpful. (per translation Gsheet)

This is still the case?

04)

Variant B: Can we keep the app bar visible when the tooltip has not been dismissed yet? It feels wrong to point to an element that is not visible (until scrolled up or screen is tapped).

https://www.dropbox.com/s/73puqjc81y6az5b/screen-20220407-122712.mp4?dl=0

Thanks a lot!!

Hi @scblr
Updated the copy... will work on the rest in a bit :)