Empty TOC in New Vector
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	IKhitron
	Feb 23 2022, 10:55 PM

Description

Hi. I'm on group 1 wiki, and I've saw the Desktop Improvements sidebar wiki. It looked nice on the Moon in test wiki, but someting has been broken during the merging. It does not work fine in so many ways. I thing the better solution is to revert the merge and fix the problems. Here is the test case:

Open this page.
Expected - a TOC on sidebar, replacing the regular one, and named "תוכן העניינים".
Got - an empty TOC box on sidebar, co-existing with the regular one, and named "Contents".

Screenshot_20220224-003939_Samsung Internet.jpg (1×1 px, 361 KB)

Or you can open the same page in reading mode, you can see the full TOC, alongside with the mentioned problems, as two TOCs, and some more - there is no "TOC preferences" button, the highlighting by bold is irrelevant to the screen current content, no section zero entry.

QA Results - Prod

AC	Status	Details
1	✅	T302461#7762500

Details

	Subject	Repo	Branch	Lines +/-
	Unset data-toc in SkinVector	mediawiki/skins/Vector	wmf/1.38.0-wmf.24	+7 -0
	Unset data-toc in SkinVector	mediawiki/skins/Vector	master	+7 -0

Customize query in gerrit

Event Timeline

IKhitron created this task.Feb 23 2022, 10:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2022, 10:55 PM

I opened the link and the link is a diff. The screenshot seems to come from https://he.wikipedia.org/w/index.php?title=ויקיפדיה:מזנון&oldid=33299679 instead? Fixing problems does not require reverting.

In T302461#7734225, Aklapper wrote:

I opened the link and the link is a diff.

Indeed. It's everywhere, and this link is just an example. Here is another one, in reading mode:

Screenshot_20220226-191001_Samsung Internet.jpg (955×1 px, 401 KB)

The screenshot seems to come from https://he.wikipedia.org/w/index.php?title=ויקיפדיה:מזנון&oldid=33299679 instead?

No, it doesn't.

Fixing problems does not require reverting.

Of course. Not for fixing, for avoiding the current situation.

Jdrewniak added a project: Web-Team-Backlog.Mar 2 2022, 10:29 PM

Jdrewniak added subscribers: ovasileva, Jdrewniak.

@IKhitron we're actively working on the table of contents and bugs like this may appear temporarily due to caching. Are you still seeing this issue?

Jdrewniak renamed this task from New TOC in New Vector to Empty TOC in New Vector.Mar 2 2022, 10:37 PM

In T302461#7749204, @Jdrewniak wrote:

@IKhitron we're actively working on the table of contents and bugs like this may appear temporarily due to caching. Are you still seeing this issue?

Well, since the deployment I opened, say, a thousand pages, view or diff modes. Exactly two of them were 90% OK, all the rest were broken. Including five minutes ago. And including safemode, too.

@IKhitron I've visited https://he.wikipedia.org/wiki/%D7%A9%D7%99%D7%97%D7%AA_%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%9E%D7%96%D7%A0%D7%95%D7%9F and I only see one table of contents in the article (and no TOC in the sidebar):

Screen Shot 2022-03-02 at 5.01.19 PM.png (2×4 px, 651 KB)

Can you please paste the full url of the page you are noticing this issue?

In T302461#7749380, @nray wrote:

@IKhitron I've visited https://he.wikipedia.org/wiki/%D7%A9%D7%99%D7%97%D7%AA_%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%9E%D7%96%D7%A0%D7%95%D7%9F and I only see one table of contents in the article (and no TOC in the sidebar):

Can you please paste the full url of the page you are noticing this issue?

Every page on wikipedia. Including the one you linked.

BTW: it's just a guess, but if I would be you, I would check synchronization. There was one page that I opened twice, once broken, and once not. Maybe something js not ready in time.

ovasileva triaged this task as High priority.Mar 3 2022, 9:15 AM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

Thank you for your report @IKhitron. Our current configuration should not allow the new ToC to show on any pages as we're still developing the functionality. We're looking into why this might be happening. Do you by any chance have the Wikipedia prototypes browser extension installed?

No problem. Well, as I said, on two pages I can see the full TOC, without definitions button. No, I don't.

ovasileva raised the priority of this task from High to Unbreak Now!.Mar 3 2022, 5:10 PM

Jdlrobson added a parent task: T300200: 1.38.0-wmf.24 deployment blockers.Mar 3 2022, 5:11 PM

Does this warrant a rollback of 1.38.0-wmf.24?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 3 2022, 5:28 PM

@brennen will be able to give you an answer within an hour.

Change 767856 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Unset data-toc in SkinVector

https://gerrit.wikimedia.org/r/767856

gerritbot added a project: Patch-For-Review.Mar 3 2022, 6:09 PM

No rollback is needed, but let's backport the above patch today.

Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 3 2022, 6:09 PM

Note: can replicate as an anonymous user in an incognito window on metawiki - ToC appears fully

Screen Shot 2022-03-03 at 7.17.36 PM.png (1×1 px, 434 KB)

Jdlrobson reassigned this task from Jdlrobson to • nray.Mar 3 2022, 6:28 PM

Change 767812 had a related patch set uploaded (by Brennen Bearnes; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.24] Unset data-toc in SkinVector

https://gerrit.wikimedia.org/r/767812

Change 767856 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Unset data-toc in SkinVector

https://gerrit.wikimedia.org/r/767856

Change 767812 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.24] Unset data-toc in SkinVector

https://gerrit.wikimedia.org/r/767812

Mentioned in SAL (#wikimedia-operations) [2022-03-03T19:30:12Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.24/skins/Vector/includes/SkinVector.php: Backport: [[gerrit:767812|Unset data-toc in SkinVector (T302461)]] (duration: 00m 49s)

brennen removed a parent task: T300200: 1.38.0-wmf.24 deployment blockers.Mar 3 2022, 7:30 PM

Jdlrobson moved this task from Code Review to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 3 2022, 7:48 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 3 2022, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2022, 8:10 PM

Confirming I can no longer reproduce on meta-wiki:

Screen Shot 2022-03-04 at 1.14.46 PM.png (1×2 px, 653 KB)

ovasileva lowered the priority of this task from Unbreak Now! to High.Mar 4 2022, 12:18 PM

Thanks. I'll write here if I see it again.

• nray reassigned this task from • nray to Edtadros.Mar 7 2022, 6:38 PM

Test Result - Prod

Status: ✅ PASS
Environment: frwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: TOC should not appear with or without the parameter on frwiki

Screen Recording 2022-03-08 at 3.17.16 PM.mov.gif (1×1 px, 964 KB)

Screen Recording 2022-03-08 at 3.18.03 PM.mov.gif (1×1 px, 993 KB)

Edtadros updated the task description. (Show Details)Mar 8 2022, 11:20 PM

ovasileva closed this task as Resolved.Mar 10 2022, 10:56 AM

	F34990582: Screen Recording 2022-03-08 at 3.17.16 PM.mov.gif
	Mar 8 2022, 11:19 PM

	F34990586: Screen Recording 2022-03-08 at 3.18.03 PM.mov.gif
	Mar 8 2022, 11:19 PM

	F34975044: Screen Shot 2022-03-04 at 1.14.46 PM.png
	Mar 4 2022, 12:15 PM

	F34974063: Screen Shot 2022-03-03 at 7.17.36 PM.png
	Mar 3 2022, 6:17 PM

	F34973011: Screen Shot 2022-03-02 at 5.01.19 PM.png
	Mar 3 2022, 12:08 AM

	F34967506: Screenshot_20220226-191001_Samsung Internet.jpg
	Feb 26 2022, 5:22 PM

	F34963683: Screenshot_20220224-003939_Samsung Internet.jpg
	Feb 23 2022, 10:55 PM

Empty TOC in New VectorClosed, ResolvedPublicBUG REPORTActions