Page MenuHomePhabricator

query_service: Simply jvm arg handling
Closed, ResolvedPublic

Description

https://github.com/wikimedia/wikidata-query-rdf/blob/75f4675cc39751adddf069f51f364dcfe72509df/dist/src/script/runBlazegraph.sh is a bit messy in the way it handles collating the various jvm_opts args. Let's simplify things.

Event Timeline

Change 761080 had a related patch set uploaded (by Ryan Kemper; author: Ebernhardson):

[operations/puppet@production] query_service: Simplify jvm arg handling

https://gerrit.wikimedia.org/r/761080

Mentioned in SAL (#wikimedia-operations) [2022-02-24T19:46:36Z] <ryankemper> T302526 Disabling puppet across entire query service (wdqs & wcqs) fleet for merge of https://gerrit.wikimedia.org/r/c/operations/puppet/+/761080: ryankemper@cumin1001:~$ sudo -E cumin 'w*qs*' 'disable-puppet "query_service: Simply jvm arg handling - T302526"'

Mentioned in SAL (#wikimedia-operations) [2022-02-24T19:48:27Z] <ryankemper> T302526 Running puppet on wdqs canary: ryankemper@wdqs1003:~$ sudo enable-puppet "query_service: Simply jvm arg handling - T302526" && sudo run-puppet-agent

Mentioned in SAL (#wikimedia-operations) [2022-02-24T19:48:50Z] <ryankemper> T302526 (Forgot to merge patch first, take two)

Change 761080 merged by Ryan Kemper:

[operations/puppet@production] query_service: Simplify jvm arg handling

https://gerrit.wikimedia.org/r/761080

Mentioned in SAL (#wikimedia-operations) [2022-02-24T19:55:22Z] <ryankemper> T302526 Depooled canary wdqs1003, ran puppet agent, and restarted wdqs-blazegraph. Tests look good, proceeding to rest of wdqs fleet

Mentioned in SAL (#wikimedia-operations) [2022-02-24T19:57:25Z] <ryankemper> T302526 ryankemper@cumin1001:~$ sudo -E cumin -b 6 'wdqs*' 'enable-puppet "query_service: Simply jvm arg handling - T302526"; sudo run-puppet-agent' in tmux deploy_window

Mentioned in SAL (#wikimedia-operations) [2022-02-24T20:02:45Z] <ryankemper> T302526 Depooled wcqs1001, ran puppet agent, and restarted wcqs-blazegraph. Service came up healthy, proceeding to rest of wcqs fleet

Mentioned in SAL (#wikimedia-operations) [2022-02-24T20:04:00Z] <ryankemper> T302526 ryankemper@cumin1001:~$ sudo -E cumin -b 3 'wcqs*' 'enable-puppet "query_service: Simply jvm arg handling - T302526"; sudo run-puppet-agent' in tmux wcqs

Successfully rolled out to the whole query service fleet. We spot checked that the service restarts correctly on wdqs1003 and wcqs1001.

Change 765652 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[operations/puppet@production] query_service: Repair oauth activation

https://gerrit.wikimedia.org/r/765652

Change 765652 merged by Ryan Kemper:

[operations/puppet@production] query_service: Repair oauth activation

https://gerrit.wikimedia.org/r/765652