Page MenuHomePhabricator

The wikimedia/aho-corasick Composer package includes benchmarking test files
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • mkdir /tmp/test
  • cd /tmp/test
  • composer require wikimedia/aho-corasick
  • ls -R vendor/wikimedia/aho-corasick

What happens?:

vendor/wikimedia/aho-corasick:
bench  LICENSE  NOTICE  README.md  src

vendor/wikimedia/aho-corasick/bench:
bench.php  check.php

vendor/wikimedia/aho-corasick/src:
MultiStringMatcher.php  MultiStringReplacer.php

What should have happened instead?:

vendor/wikimedia/aho-corasick:
LICENSE  NOTICE  README.md  src

vendor/wikimedia/aho-corasick/src:
MultiStringMatcher.php  MultiStringReplacer.php

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

n/a

Analysis

You should use .gitattributes to set export-ignore for the bench directory so it isn't included in the Composer package download.

diff --git a/.gitattributes b/.gitattributes
index 0549c6d..f1da3e8 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -6,5 +6,6 @@ Doxyfile export-ignore
 composer.json export-ignore
 .phpcs.xml export-ignore
 phpunit.xml.dist export-ignore
+bench/ export-ignore
 build/ export-ignore
 tests/ export-ignore

Details

Event Timeline

Change 765630 had a related patch set uploaded (by Reedy; author: Reedy):

[AhoCorasick@master] .gitattributes: Add bench folder as export-ignore

https://gerrit.wikimedia.org/r/765630

Change 765630 merged by jenkins-bot:

[AhoCorasick@master] .gitattributes: Add bench folder as export-ignore

https://gerrit.wikimedia.org/r/765630