Add config to disallow extra fields in some json schema objects
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bd808
	Feb 24 2022, 9:57 PM

Description

Investigation of T301897: Unexpected "isTrusted" value showing up in some author diff output revealed an invalid assumption that json schema defined objects have a closed set of allowed properties by default. As documented upstream, by default any additional properties are allowed. Adding an explicit "additionalProperties": false setting to a "type": "object" definition means no additional properties will be allowed.

For the toolinfo.json schema we should add the "additionalProperties": false setting to all objects other than the "tool" object. This turns out to affect only two defined types, "url_multilingual" and "person" in practice.

Details

	Subject	Repo	Branch	Lines +/-
	toolhub: Bump container version to 2022-03-15-002555-production	operations/deployment-charts	master	+1 -1
	schema: exclude extra properties for url_multilingual and person types	wikimedia/toolhub	main	+17 -2

Customize query in gerrit

Related Objects

Mentioned Here: T301897: Unexpected "isTrusted" value showing up in some author diff output

Event Timeline

bd808 created this task.Feb 24 2022, 9:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2022, 9:57 PM

bd808 changed the task status from Open to In Progress.Feb 24 2022, 9:57 PM

bd808 claimed this task.

bd808 triaged this task as Medium priority.

bd808 moved this task from Backlog to In Progress on the Toolhub board.

Restricted Application added a project: User-bd808. · View Herald TranscriptFeb 24 2022, 9:57 PM

What is this task, huh?

bd808 removed a subscriber: • Lipsum_Love255.Feb 24 2022, 10:46 PM

Change 765650 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] schema: exclude extra properties for url_multilingual and person types

https://gerrit.wikimedia.org/r/765650

gerritbot added a project: Patch-For-Review.Feb 24 2022, 10:54 PM

bd808 moved this task from In Progress to Review on the Toolhub board.Feb 24 2022, 10:54 PM

Change 765650 merged by jenkins-bot:

[wikimedia/toolhub@main] schema: exclude extra properties for url_multilingual and person types

https://gerrit.wikimedia.org/r/765650

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2022, 9:10 AM

bd808 closed this task as Resolved.Feb 25 2022, 4:54 PM

Change 770638 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638

gerritbot added a project: Patch-For-Review.Mar 15 2022, 12:34 AM

Change 770638 merged by jenkins-bot: