Page MenuHomePhabricator
Create Task
Maniphest T302599

Increase code coverage of all WikiLambda PHP ZObjects code to 100% of lines and methods (or marked as ignored if structural)
Open, LowPublic
Actions

Description

https://doc.wikimedia.org/cover-extensions/WikiLambda/includes/ZObjects/index.html

  • StringForLanguageBuilder.php
  • ZError.php
  • ZFunction.php
  • ZFunctionCall.php
  • ZKey.php
  • ZKeyReference.php
  • ZMonoLingualString.php
  • ZMonoLingualStringSet.php
  • ZMultiLingualString.php
  • ZMultiLingualStringSet.php
  • ZObject.php
  • ZPersistentObject.php
  • ZQuote.php
  • ZReference.php
  • ZResponseEnvelope.php
  • ZString.php
  • ZType.php
  • ZTypedError.php
  • ZTypedList.php
  • ZTypedMap.php
  • ZTypedPair.php

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 25 2022, 4:01 PM
Jdforrester-WMF added a subtask: T294826: WikiLambda: Add ZObject::getSerialized() unit tests.
DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Mar 8 2022, 5:06 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:44 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:38 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF triaged this task as Low priority.Mar 24 2023, 1:05 AM
Jdforrester-WMF changed the status of subtask T294826: WikiLambda: Add ZObject::getSerialized() unit tests from Open to In Progress.Oct 26 2023, 4:51 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 18 2024, 9:13 PM
gerritbot added a comment.Jan 18 2024, 10:05 PM

Change 991666 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Fill in some coverage for ZKey, ZReference, ZMonolingualString

https://gerrit.wikimedia.org/r/991666

gerritbot added a project: Patch-For-Review.Jan 18 2024, 10:05 PM

Change 991667 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Fill in some coverage for ZError

https://gerrit.wikimedia.org/r/991667

gerritbot added a comment.Jan 19 2024, 1:43 AM

Change 991666 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Fill in some coverage for ZKey, ZReference, ZMonolingualString

https://gerrit.wikimedia.org/r/991666

gerritbot added a comment.Jan 19 2024, 1:43 AM

Change 991667 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Fill in some coverage for ZError

https://gerrit.wikimedia.org/r/991667

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2024, 2:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 19 2024, 7:00 AM
Jdforrester-WMF updated the task description. (Show Details)Jan 19 2024, 3:56 PM
gerritbot added a comment.Jan 19 2024, 4:18 PM

Change 991796 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZMultiLingualStringTest: Test getSerialized and getValueAsList to reach 100%

https://gerrit.wikimedia.org/r/991796

gerritbot added a project: Patch-For-Review.Jan 19 2024, 4:18 PM
gerritbot added a comment.Jan 19 2024, 6:47 PM

Change 991796 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZMultiLingualStringTest: Test getSerialized and getValueAsList to reach 100%

https://gerrit.wikimedia.org/r/991796

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2024, 7:30 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 22 2024, 2:52 PM
gerritbot added a comment.Jan 22 2024, 10:11 PM

Change 992247 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZMultiLingualStringTest: Complete StringForLanguageBuilder coverage

https://gerrit.wikimedia.org/r/992247

gerritbot added a project: Patch-For-Review.Jan 22 2024, 10:11 PM
gerritbot added a comment.Jan 23 2024, 5:03 PM

Change 992463 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Cover the second parameter of ZPersistentObject::getLabel()

https://gerrit.wikimedia.org/r/992463

gerritbot added a comment.Jan 23 2024, 5:03 PM

Change 992464 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Cover ZPersistentObject::getDescriptions()

https://gerrit.wikimedia.org/r/992464

gerritbot added a comment.Jan 23 2024, 5:03 PM

Change 992465 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Cover ZObject::setValueByKey() and ::getZValue()

https://gerrit.wikimedia.org/r/992465

gerritbot added a comment.Jan 23 2024, 6:03 PM

Change 992247 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZMultiLingualStringTest: Complete StringForLanguageBuilder coverage

https://gerrit.wikimedia.org/r/992247

gerritbot added a comment.Jan 23 2024, 6:03 PM

Change 992463 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Cover the second parameter of ZPersistentObject::getLabel()

https://gerrit.wikimedia.org/r/992463

gerritbot added a comment.Jan 23 2024, 6:03 PM

Change 992464 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Cover ZPersistentObject::getDescriptions()

https://gerrit.wikimedia.org/r/992464

gerritbot added a comment.Jan 23 2024, 6:03 PM

Change 992465 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Cover ZObject::setValueByKey() and ::getZValue()

https://gerrit.wikimedia.org/r/992465

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2024, 6:31 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 23 2024, 6:47 PM
gerritbot added a comment.Jan 23 2024, 6:55 PM

Change 992483 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Test getLabel() both ways to demonstrate drift

https://gerrit.wikimedia.org/r/992483

gerritbot added a project: Patch-For-Review.Jan 23 2024, 6:55 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 23 2024, 7:00 PM
gerritbot added a comment.Jan 23 2024, 7:24 PM

Change 992485 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZFunctionTest: Test ZObject::getZValue() and inner mechanics

https://gerrit.wikimedia.org/r/992485

gerritbot added a comment.Jan 23 2024, 7:42 PM

Change 992488 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Cover Z4K4–8 getters and getZKey()

https://gerrit.wikimedia.org/r/992488

gerritbot added a comment.Jan 23 2024, 7:42 PM

Change 992489 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjects: Drop duplicate re-definitions of getZValue()

https://gerrit.wikimedia.org/r/992489

gerritbot added a comment.Jan 23 2024, 8:21 PM

Change 992483 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Test getLabel() both ways to demonstrate drift

https://gerrit.wikimedia.org/r/992483

gerritbot added a comment.Jan 23 2024, 8:21 PM

Change 992485 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZFunctionTest: Test ZObject::getZValue() and inner mechanics

https://gerrit.wikimedia.org/r/992485

gerritbot added a comment.Jan 24 2024, 3:25 PM

Change 992488 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypeTest: Cover Z4K4–8 getters and getZKey()

https://gerrit.wikimedia.org/r/992488

gerritbot added a comment.Jan 24 2024, 5:25 PM

Change 992489 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjects: Drop duplicate re-definitions of getZValue()

https://gerrit.wikimedia.org/r/992489

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2024, 5:32 PM
gerritbot added a comment.Jan 24 2024, 7:37 PM

Change 992805 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZStringTest: Cover the constructor completely

https://gerrit.wikimedia.org/r/992805

gerritbot added a project: Patch-For-Review.Jan 24 2024, 7:37 PM
gerritbot added a comment.Jan 30 2024, 6:05 PM

Change 992805 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZStringTest: Cover the constructor completely

https://gerrit.wikimedia.org/r/992805

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.17; 2024-02-06); removed MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 30 2024, 7:00 PM
gerritbot added a comment.Feb 7 2024, 5:17 PM

Change 998476 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Extend coverage of ZResponseEnvelope, fix bug

https://gerrit.wikimedia.org/r/998476

gerritbot added a comment.Feb 7 2024, 5:44 PM

Change 998476 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Extend coverage of ZResponseEnvelope, fix bug

https://gerrit.wikimedia.org/r/998476

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2024, 6:31 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.18; 2024-02-13); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Feb 7 2024, 10:01 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Feb 22 2024, 10:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL