Page MenuHomePhabricator
Create Task
Maniphest T302678

PHP Notice: Trying to get property 't' of non-object (LanguageVariantHandler)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 't' of non-object
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/LanguageVariantHandler.php(263)
#0 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/LanguageVariantHandler.php(263): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 [internal function]: Wikimedia\Parsoid\Html2Wt\LanguageVariantHandler::Wikimedia\Parsoid\Html2Wt\{closure}(NULL, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/LanguageVariantHandler.php(273): array_map(Closure, array, array)
#3 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(151): Wikimedia\Parsoid\Html2Wt\LanguageVariantHandler::handleLanguageVariant(Wikimedia\Parsoid\Html2Wt\SerializerState, Wikimedia\Parsoid\DOM\Element)
#4 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/DOMHandlers/EncapsulatedContentHandler.php(86): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->languageVariantHandler(Wikimedia\Parsoid\DOM\Element)
#5 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1258): Wikimedia\Parsoid\Html2Wt\DOMHandlers\EncapsulatedContentHandler->handle(Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#6 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNodeInternal(Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Html2Wt\DOMHandlers\EncapsulatedContentHandler)
#7 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1351): call_user_func(array, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Html2Wt\DOMHandlers\EncapsulatedContentHandler)
#8 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/SerializerState.php(708): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(Wikimedia\Parsoid\DOM\Element)
#9 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/DOMHandlers/PHandler.php(32): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(Wikimedia\Parsoid\DOM\Element)
#10 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1258): Wikimedia\Parsoid\Html2Wt\DOMHandlers\PHandler->handle(Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Html2Wt\SerializerState, boolean)
#11 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNodeInternal(Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Html2Wt\DOMHandlers\PHandler)
#12 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1351): call_user_func(array, Wikimedia\Parsoid\DOM\Element, Wikimedia\Parsoid\Html2Wt\DOMHandlers\PHandler)
#13 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/SerializerState.php(708): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(Wikimedia\Parsoid\DOM\Element)
#14 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/SerializerState.php(734): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(Wikimedia\Parsoid\DOM\Element, NULL)
#15 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1620): Wikimedia\Parsoid\Html2Wt\SerializerState->kickOffSerialize(Wikimedia\Parsoid\DOM\Element)
#16 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Html2Wt/SelectiveSerializer.php(239): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOM(Wikimedia\Parsoid\DOM\Element, boolean)
#17 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(186): Wikimedia\Parsoid\Html2Wt\SelectiveSerializer->serializeDOM(Wikimedia\Parsoid\DOM\Document)
#18 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/src/Parsoid.php(284): Wikimedia\Parsoid\Wikitext\ContentModelHandler->fromDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, Wikimedia\Parsoid\Core\SelserData)
#19 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(863): Wikimedia\Parsoid\Parsoid->dom2wikitext(MWParsoid\Config\PageConfig, Wikimedia\Parsoid\DOM\Document, array, Wikimedia\Parsoid\Core\SelserData)
#20 /srv/mediawiki/php-1.38.0-wmf.23/vendor/wikimedia/parsoid/extension/src/Rest/Handler/TransformHandler.php(133): MWParsoid\Rest\Handler\ParsoidHandler->html2wt(MWParsoid\Config\PageConfig, array, string)
#21 /srv/mediawiki/php-1.38.0-wmf.23/includes/Rest/Router.php(414): MWParsoid\Rest\Handler\TransformHandler->execute()
#22 /srv/mediawiki/php-1.38.0-wmf.23/includes/Rest/Router.php(338): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\TransformHandler)
#23 /srv/mediawiki/php-1.38.0-wmf.23/includes/Rest/EntryPoint.php(167): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#24 /srv/mediawiki/php-1.38.0-wmf.23/includes/Rest/EntryPoint.php(132): MediaWiki\Rest\EntryPoint->execute()
#25 /srv/mediawiki/php-1.38.0-wmf.23/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#26 /srv/mediawiki/w/rest.php(3): require(string)
#27 {main}
Impact
Notes

Details

Request URL
https://zh.wikipedia.org/w/rest.php/zh.wikipedia.org/v3/transform/pagebundle/to/wikitext/%E6%B8%AF%E5%8F%B0%E9%9B%BB%E8%A6%9632/70361161
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump parsoid to 0.17.0-a11mediawiki/vendormaster+444 -148
Serialize empty twoway key in language variantmediawiki/services/parsoidmaster+13 -3
Customize query in gerrit

Event Timeline

ssastry created this task.Feb 27 2022, 2:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2022, 2:30 PM
Krinkle moved this task from Untriaged to Feb 2022 on the Wikimedia-production-error board.Feb 28 2022, 2:53 PM
ihurbain claimed this task.Mar 1 2022, 3:53 PM
ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Mar 4 2022, 7:22 PM
ssastry triaged this task as Medium priority.Mar 9 2022, 1:04 AM
ihurbain removed ihurbain as the assignee of this task.May 3 2022, 3:24 PM
ihurbain subscribed.
gerritbot added a comment.Jan 10 2023, 10:11 PM

Change 878204 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Serialize empty twoway key in language variant

https://gerrit.wikimedia.org/r/878204

gerritbot added a project: Patch-For-Review.Jan 10 2023, 10:11 PM
Arlolra claimed this task.Jan 10 2023, 10:11 PM
Arlolra added a project: Content-Transform-Team-WIP.
Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.Jan 10 2023, 11:03 PM

Change 878204 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Serialize empty twoway key in language variant

https://gerrit.wikimedia.org/r/878204

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Jan 10 2023, 11:45 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 11 2023, 12:31 AM
gerritbot added a comment.Jan 16 2023, 5:10 PM

Change 880501 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a11

https://gerrit.wikimedia.org/r/880501

gerritbot added a project: Patch-For-Review.Jan 16 2023, 5:10 PM
gerritbot added a comment.Jan 16 2023, 5:48 PM

Change 880501 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a11

https://gerrit.wikimedia.org/r/880501

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2023, 6:32 PM
ssastry moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Jan 17 2023, 3:33 PM
Arlolra closed this task as Resolved.Jan 18 2023, 3:31 AM

This patch has rolled out to group0 wikis

λ (master) curl -d "html=<p><meta typeof=\"mw:LanguageVariant\" data-mw-variant='{\"twoway\":[]}'/></p>" -X POST https://www.mediawiki.org/api/rest_v1/transform/html/to/wikitext
-{H|}-

While group2 is still running the last tagged version of Parsoid,

λ (master) curl -d "html=<p><meta typeof=\"mw:LanguageVariant\" data-mw-variant='{\"twoway\":[]}'/></p>" -X POST https://en.wikipedia.org/api/rest_v1/transform/html/to/wikitext
{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/unknown_error","method":"post","uri":"/en.wikipedia.org/v1/transform/html/to/wikitext"}

Resulting in the error from the task description,
https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2023.01.18?id=MJjpwoUBDKoS4s0HQP-v

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits