Page MenuHomePhabricator
Create Task
Maniphest T302724

Include translation test results in server response
Closed, ResolvedPublic
Actions

Description

A possible (test-driven-development-like) Web2Cit workflow is:

  1. Find a target URL that returns unexpected results in Citoid
  2. Confirm Web2Cit returns unexpected results as well
  3. Write a test for the target URL
  4. Write a template for the target URL until all domain tests pass. Write patterns if needed.
  5. Repeat

To support this workflow, we need a way to check how test results change after making configuration changes. This will be supported by the Web2Cit-Editor.

In the meantime, consider providing an additional endpoint (maybe just the debug endpoint T301748 with a search query ?tests) that shows these results.

Related Objects
Search...

Event Timeline

diegodlh created this task.Feb 28 2022, 3:25 PM
diegodlh added a subtask: T302722: Add test configuration support.
diegodlh mentioned this in T305750: Implement a base endpoint, controlled by query string parameters.Apr 13 2022, 12:53 PM

The test endpoint should have the option to: (1) show test results for a single target URL, and (2) show test results for all tests configured for a domain.

diegodlh renamed this task from Consider providing an additional "tests" endpoint to Include translation test results in server response.Apr 13 2022, 8:27 PM
diegodlh moved this task from Backlog to To do on the Web2Cit-Server board.
diegodlh moved this task from To do to Doing on the Web2Cit-Server board.
diegodlh added a comment.Apr 13 2022, 8:31 PM

Instead of having a separate /test/ endpoint, include tests (expected outputs and test scores) along with translation outputs, and provide a query string parameter (see T305750) to either enable or disable including these tests.

diegodlh added a subtask: T302695: Use "views" to render HTML responses.Apr 13 2022, 9:08 PM
diegodlh closed subtask T302695: Use "views" to render HTML responses as Resolved.Apr 21 2022, 5:20 PM

We now have a placeholder for expected outputs in our result tables.

diegodlh moved this task from Doing to To do on the Web2Cit-Server board.Apr 28 2022, 6:35 PM
diegodlh closed this task as Resolved.Jun 13 2022, 2:55 PM
diegodlh claimed this task.
diegodlh closed subtask T302722: Add test configuration support as Resolved.
diegodlh moved this task from To do to Done on the Web2Cit-Server board.

Implemented on the translation-tests branch.

diegodlh mentioned this in T310518: Add a shortcut to translate all template + test paths to Web2Cit homepage.Jun 13 2022, 3:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL