Page MenuHomePhabricator
Create Task
Maniphest T302746

Post-edit dialog does not appear for newcomer task edits
Closed, ResolvedPublicBUG REPORT
Actions

Description

rEVEDc8072f1af24c: Move methods from DesktopArticleTraget to ArticleTarget broke the post-edit dialog from loading after a user makes an edit on a task from Special:Homepage.

There are patches already to fix this in VE; linking with this task to facilitate QA.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditorwmf/1.38.0-wmf.23+3 -0Don't let MobileFrontend show abandonedit after saveComplete
mediawiki/extensions/VisualEditorwmf/1.38.0-wmf.23+10 -6Make sure postEdit hook doesn't fire until after saveComplete is done
mediawiki/extensions/VisualEditormaster+10 -6Make sure postEdit hook doesn't fire until after saveComplete is done
mediawiki/extensions/VisualEditormaster+3 -0Don't let MobileFrontend show abandonedit after saveComplete
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Feb 28 2022, 8:55 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 28 2022, 8:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Feb 28 2022, 8:56 PM

Change 765604 had a related patch set uploaded (by Kosta Harlan; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Don't let MobileFrontend show abandonedit after saveComplete

https://gerrit.wikimedia.org/r/765604

gerritbot added a project: Patch-For-Review.Feb 28 2022, 8:56 PM

Change 765605 had a related patch set uploaded (by Kosta Harlan; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Make sure postEdit hook doesn't fire until after saveComplete is done

https://gerrit.wikimedia.org/r/765605

kostajh triaged this task as High priority.Feb 28 2022, 8:56 PM
kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.

(High priority for Growth-Team, as the post-edit dialog is a key component of Growth features.)

gerritbot added a comment.Feb 28 2022, 9:02 PM

Change 766799 had a related patch set uploaded (by Kosta Harlan; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.23] Don't let MobileFrontend show abandonedit after saveComplete

https://gerrit.wikimedia.org/r/766799

gerritbot added a comment.Feb 28 2022, 9:02 PM

Change 766800 had a related patch set uploaded (by Kosta Harlan; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.23] Make sure postEdit hook doesn't fire until after saveComplete is done

https://gerrit.wikimedia.org/r/766800

kostajh changed the subtype of this task from "Task" to "Bug Report".Feb 28 2022, 9:09 PM
MMiller_WMF moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.Feb 28 2022, 9:12 PM
gerritbot added a comment.Feb 28 2022, 9:19 PM

Change 765604 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't let MobileFrontend show abandonedit after saveComplete

https://gerrit.wikimedia.org/r/765604

gerritbot added a comment.Feb 28 2022, 9:19 PM

Change 765605 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make sure postEdit hook doesn't fire until after saveComplete is done

https://gerrit.wikimedia.org/r/765605

gerritbot added a comment.Feb 28 2022, 9:26 PM

Change 766800 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.23] Make sure postEdit hook doesn't fire until after saveComplete is done

https://gerrit.wikimedia.org/r/766800

gerritbot added a comment.Feb 28 2022, 9:26 PM

Change 766799 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.23] Don't let MobileFrontend show abandonedit after saveComplete

https://gerrit.wikimedia.org/r/766799

Stashbot added a comment.Feb 28 2022, 9:38 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-28T21:38:50Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/extensions/VisualEditor/modules/ve-mw/init/targets: rEVEDe22e4d58aefa: rEVEDb4dd4c420771: VisualEditor backports (T302746) (duration: 00m 51s)

kostajh claimed this task.Feb 28 2022, 9:48 PM
kostajh moved this task from In Progress to QA on the Growth-Team (Current Sprint) board.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 28 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 28 2022, 10:11 PM
Etonkovidova closed this task as Resolved.Mar 1 2022, 3:58 AM
Etonkovidova added a subscriber: Etonkovidova.

Checked on testwiki wmf.23 - all seem to work as expected.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL