Maniphest T302749

Remove Quotes from User-Defined Validation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Feb 28 2022, 9:25 PM

Tags

Referenced Files

None

Subscribers

Description

We currently wrap the arguments to validation functions in Z99 in order to prevent evaluation thereof. We shouldn't do this for user-defined validation, which takes place dynamically (so the arguments should already have been evaluated).

Details

	Subject	Repo	Branch	Lines +/-
	Don't quote input to user-defined validation function.	mediawiki/extensions/WikiLambda	master	+1 -1
	Do not quote user-defined validation functions.	mediawiki/services/function-orchestrator	master	+57 -15

Customize query in gerrit

Related Objects

Mentioned In: T301509: Discuss How/Whether to Avoid Quotes in Validation Functions
rMSFO6e9fffe5cdbc: Do not quote user-defined validation functions.

Event Timeline

cmassaro created this task.Feb 28 2022, 9:25 PM

Change 766864 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Do not quote user-defined validation functions.

https://gerrit.wikimedia.org/r/766864

Change 766865 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Don't quote input to user-defined validation function.

https://gerrit.wikimedia.org/r/766865

cmassaro claimed this task.Mar 1 2022, 7:55 PM

cmassaro added a project: function-orchestrator.

Change 766864 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Do not quote user-defined validation functions.

https://gerrit.wikimedia.org/r/766864

cmassaro mentioned this in rMSFO6e9fffe5cdbc: Do not quote user-defined validation functions..Mar 2 2022, 4:02 PM

Change 766865 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Don't quote input to user-defined validation function.

https://gerrit.wikimedia.org/r/766865

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2022, 4:10 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 2 2022, 5:00 PM

Jdforrester-WMF mentioned this in T301509: Discuss How/Whether to Avoid Quotes in Validation Functions.Mar 2 2022, 10:09 PM

DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Mar 8 2022, 5:09 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 8 2022, 5:09 PM

DVrandecic closed this task as Resolved.Mar 8 2022, 5:30 PM