Page MenuHomePhabricator
Create Task
Maniphest T302753

[Regression, wmf.24-mobile] Search icon is misplaced
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Description

The issue is present now on testwiki wmf.24

enwiki betalabs mobiletestwiki mobile wmf.23
Screen Shot 2022-02-28 at 3.35.19 PM.png (1×730 px, 185 KB)
Screen Shot 2022-02-28 at 3.34.28 PM.png (1×724 px, 198 KB)

Notes:

  • the issue is present on mobile only (the browser emulator and a real device-iOS and Android)
  • the issue is present in Vector 2022/legacy Vector

Details

SubjectRepoBranchLines +/-
Remove user navigation min width and widthmediawiki/skins/MinervaNeuewmf/1.38.0-wmf.24+1 -1
Remove user navigation min width and widthmediawiki/skins/MinervaNeuemaster+1 -1
Update user menu styling and remove CSS for cached HTMLmediawiki/skins/MinervaNeuemaster+0 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Feb 28 2022, 11:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2022, 11:46 PM
Etonkovidova renamed this task from [betalabs-mobile] Search icon is misplaced to [wmf.24-mobile] Search icon is misplaced .Mar 1 2022, 11:15 PM
Etonkovidova added a project: Regression.
Etonkovidova updated the task description. (Show Details)
Jdrewniak added a project: Web-Team-Backlog-Archived.Mar 2 2022, 11:06 PM
ovasileva triaged this task as High priority.Mar 3 2022, 9:40 AM
ovasileva edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived.
gerritbot added a comment.Mar 3 2022, 4:22 PM

Change 767833 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Update user menu styling and remove CSS for cached HTML

https://gerrit.wikimedia.org/r/767833

gerritbot added a project: Patch-For-Review.Mar 3 2022, 4:22 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Mar 3 2022, 5:28 PM
Jdlrobson renamed this task from [wmf.24-mobile] Search icon is misplaced to [Regression, wmf.24-mobile] Search icon is misplaced .Mar 3 2022, 5:32 PM
Jdlrobson claimed this task.
Jdlrobson added a parent task: T301257: [Regression] Can't search on mobile on grade C browsers.
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Upcoming to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Mar 3 2022, 5:53 PM

Change 767852 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove user navigation min width and width

https://gerrit.wikimedia.org/r/767852

Jdlrobson removed Jdlrobson as the assignee of this task.Mar 3 2022, 5:54 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Mar 3 2022, 6:05 PM

Change 767833 abandoned by Bernard Wang:

[mediawiki/skins/MinervaNeue@master] Update user menu styling and remove CSS for cached HTML

Reason:

https://gerrit.wikimedia.org/r/767833

ovasileva subscribed.Mar 3 2022, 6:20 PM
Jdlrobson assigned this task to bwang.Mar 3 2022, 6:27 PM
gerritbot added a comment.Mar 3 2022, 6:45 PM

Change 767811 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.24] Remove user navigation min width and width

https://gerrit.wikimedia.org/r/767811

gerritbot added a comment.Mar 3 2022, 6:47 PM

Change 767852 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove user navigation min width and width

https://gerrit.wikimedia.org/r/767852

bwang reassigned this task from bwang to Edtadros.Mar 3 2022, 6:58 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
bwang subscribed.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 3 2022, 7:00 PM
gerritbot added a comment.Mar 3 2022, 7:18 PM

Change 767811 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.24] Remove user navigation min width and width

https://gerrit.wikimedia.org/r/767811

Stashbot added a comment.Mar 3 2022, 7:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-03T19:23:56Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.24/skins/MinervaNeue/resources/skins.minerva.base.styles/userMenu.less: Backport: [[gerrit:767811|Remove user navigation min width and width (T302753)]] (duration: 00m 51s)

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Mar 3 2022, 7:48 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.24; 2022-02-28); removed MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 3 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 3 2022, 8:12 PM
Etonkovidova closed this task as Resolved.Mar 3 2022, 9:08 PM

Checked on testwiki wmf.24 and eswiki wmf.24 (both desktop/mobile) - the placement of the search icon looks as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits