Page MenuHomePhabricator
Create Task
Maniphest T302782

[M] Edit Task: Fix uses of (error|success|warning|message)box in MachineVision
Closed, ResolvedPublic
Actions

Description

See T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release for details.

Details

SubjectRepoBranchLines +/-
warningbox class is deprecated, use Html classmediawiki/extensions/MachineVisionmaster+6 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

SimoneThisDot created this task.Mar 1 2022, 10:11 AM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMar 1 2022, 10:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Mar 7 2022, 5:33 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jdlrobson added a subscriber: Jdlrobson.Mar 8 2022, 4:26 PM

We are planning to drop these styles at the beginning of April. You can use this patch to see how this impacts your interfaces.

CBogen renamed this task from Edit Task: Fix uses of (error|success|warning|message)box in MachineVision to [M] Edit Task: Fix uses of (error|success|warning|message)box in MachineVision.Mar 9 2022, 5:38 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Mar 9 2022, 5:42 PM
gerritbot added a comment.Mar 21 2022, 8:41 PM

Change 772500 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MachineVision@master] warningbox class is deprecated, use Html class

https://gerrit.wikimedia.org/r/772500

gerritbot added a project: Patch-For-Review.Mar 21 2022, 8:41 PM
Jdlrobson added a comment.Mar 21 2022, 8:42 PM

Disclaimer: Above patch is untested.

SimoneThisDot added a comment.Mar 22 2022, 8:30 AM

I will test it while reviewing it for you!

SimoneThisDot assigned this task to Jdlrobson.Mar 23 2022, 8:38 AM
SimoneThisDot moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Mar 23 2022, 9:04 AM

Change 772500 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] warningbox class is deprecated, use Html class

https://gerrit.wikimedia.org/r/772500

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 9:10 AM
gerritbot added a comment.Mar 23 2022, 9:20 AM

Change 773189 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/UploadWizard@master] Fix uses of (error|success|warning|message)box in UploadWizard

https://gerrit.wikimedia.org/r/773189

gerritbot added a project: Patch-For-Review.Mar 23 2022, 9:20 AM
SimoneThisDot changed the task status from Open to In Progress.Mar 23 2022, 9:23 AM
SimoneThisDot moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.

For QA purposes, the error was shown when the browser has "no javascript enabled".

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 23 2022, 10:00 AM
Jdlrobson removed Jdlrobson as the assignee of this task.Mar 28 2022, 3:26 PM
Etonkovidova closed this task as Resolved.Mar 30 2022, 11:36 PM
Etonkovidova claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL