I think i covered all the AC:s here https://github.com/wbstack/api/pull/404

Boat wifi currently only gives me ~250 kb/s so can't boot minikube to try it out.

This seems to totally work as expected. Gonna move it to review.

Reset Password Notification text verified! Other two remaining to be checked.

I note however that it seems that the email footer has not been adjusted as requested.

Email includes

This message was sent from an unmonitored account. You can get in touch with the Wikibase team through our contact page.

[word Contact is a link to http://api.wikibase.cloud/contact -- not existing]

It is meant to be:

This message was sent from an unmonitored account. You can get in touch with the Wikibase team through our Contact page.

[word Contact is a link to https://wikiba.se/contact]

Still to be changed: URL, and capitalization of "contact"

In T302867#7839461, @WMDE-leszek wrote:

Reset Password Notification text verified! Other two remaining to be checked.

I note however that it seems that the email footer has not been adjusted as requested.

Email includes

This message was sent from an unmonitored account. You can get in touch with the Wikibase team through our contact page.

[word Contact is a link to http://api.wikibase.cloud/contact -- not existing]

It is meant to be:

This message was sent from an unmonitored account. You can get in touch with the Wikibase team through our Contact page.

[word Contact is a link to https://wikiba.se/contact]

Still to be changed: URL, and capitalization of "contact"

Thanks for spotting the diffs.

Looking at this ticket T293151: Rewrite a UI away from "wbstack" toward "wikibase.cloud" there seems to have been an effort to rewrite contact links to https://wikiba.se/contact I don't know why, but i'm guessing because the contact page points to adam https://www.wikibase.cloud/contact.

I've added a PR for the capitalization and will await what to do about the links https://github.com/wbstack/api/pull/411

Well, link in this ticket actually also says it should go to wikiba.se so I think that is "correct"

So https://www.wikibase.cloud/contact should probably be removed, it is something for other task though (as I get it is not exposed to the user in any way no more).

However, my comment was about the email footer linking to https://api.wikibase.cloud/contact which not existing page. That should link to wikiba.se/contact too.

"Account Creation Notification" email text looks good (except for the known differences in the footer)

So the https://api.wikibase.cloud seems to come from us incorrectly setting the services.app.url variable

This pr introduces a new variable for this and stops re-using the old one incorrectly. https://github.com/wmde/wbaas-deploy/pull/205

The problem is however two-fold, with this "custom" link to wikiba.se the template needs to use a new variable and not rely on the services.app.url as this should point to https://wikibase.cloud.

So after a chat with @WMDE-leszek the easiest way for now is to just hardcode the custom in the template too as this is whats done on other places for the ui.

This is what needs review.

https://github.com/wbstack/api/pull/411
https://github.com/wmde/wbaas-deploy/pull/205

"Email Verification" email text looks okay. Footer also adjusted as requested. Thanks!