GlobalRename: TypeError: Argument 1 passed to MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameRequestStore::newFromId() must be of the type integer, string given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Mar 2 2022, 10:09 PM

Description

Error

mwversion: 1.38.0-wmf.24
reqId: 2f558726-c679-44e1-a349-41ac9ac963d2
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameRequestStore::newFromId() must be of the type integer, string given, called in /srv/mediawiki/php-1.38.0-wmf.24/extensions/CentralAuth/inc

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.24/extensions/CentralAuth/includes/GlobalRename/GlobalRenameRequestStore.php(137)
#0 /srv/mediawiki/php-1.38.0-wmf.24/extensions/CentralAuth/includes/Special/SpecialGlobalRenameQueue.php(291): MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameRequestStore->newFromId(string)
#1 /srv/mediawiki/php-1.38.0-wmf.24/extensions/CentralAuth/includes/Special/SpecialGlobalRenameQueue.php(131): MediaWiki\Extension\CentralAuth\Special\SpecialGlobalRenameQueue->handleProcessRequest(array)
#2 /srv/mediawiki/php-1.38.0-wmf.24/includes/specialpage/SpecialPage.php(671): MediaWiki\Extension\CentralAuth\Special\SpecialGlobalRenameQueue->execute(string)
#3 /srv/mediawiki/php-1.38.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(string)
#4 /srv/mediawiki/php-1.38.0-wmf.24/includes/MediaWiki.php(315): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#5 /srv/mediawiki/php-1.38.0-wmf.24/includes/MediaWiki.php(910): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.38.0-wmf.24/includes/MediaWiki.php(564): MediaWiki->main()
#7 /srv/mediawiki/php-1.38.0-wmf.24/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.38.0-wmf.24/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Impact

Unclear.

Notes

2 of these since deploy of 1.38.0-wmf.24 (T300200) to group1.

Details

Request URL: https://meta.wikimedia.org/wiki/Special:GlobalRenameQueue/request/

	Subject	Repo	Branch	Lines +/-
	Stop throwing fatals when invalid globalrename request id is given	mediawiki/extensions/CentralAuth	master	+12 -4

Customize query in gerrit

Related Objects

Mentioned Here: T300200: 1.38.0-wmf.24 deployment blockers

Event Timeline

brennen created this task.Mar 2 2022, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2022, 10:09 PM

brennen renamed this task from TypeError: Argument 1 passed to MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameRequestStore::newFromId() must be of the type integer, string given, called in /srv/mediawiki/php-1.38.0-wmf.24/extensions/CentralAuth/includes/Special/SpecialGlobalRenameQueue.php on line 291 to GlobalRename: TypeError: Argument 1 passed to MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameRequestStore::newFromId() must be of the type integer, string given.Mar 2 2022, 10:10 PM

brennen added a project: User-brennen.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Impact

Unclear.

There is no impact, it is just missing protection against bad input. A valid url would be https://meta.wikimedia.org/wiki/Special:GlobalRenameQueue/request/85988.

The error shows up when I go to https://meta.wikimedia.org/wiki/Special:GlobalRenameQueue/request/test, because 'test' is not an integer.

Change 768261 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Stop throwing fatals when invalid globalrename request id is given

https://gerrit.wikimedia.org/r/768261

gerritbot added a project: Patch-For-Review.Mar 5 2022, 11:21 PM

Zabe claimed this task.Mar 5 2022, 11:26 PM

Change 768261 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Stop throwing fatals when invalid globalrename request id is given

https://gerrit.wikimedia.org/r/768261

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 6 2022, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2022, 12:10 AM

Zabe closed this task as Resolved.Mar 6 2022, 12:11 AM

Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 14 2022, 4:15 PM

GlobalRename: TypeError: Argument 1 passed to MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameRequestStore::newFromId() must be of the type integer, string givenClosed, ResolvedPublicPRODUCTION ERRORActions