Hiding unused parameters makes the sidebar jump to the wrong header in some cases
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-Fisch
	Mar 3 2022, 10:41 AM

Description

On a multipart transclusion with at least two templates and a longer list of parameters on both, hiding the unused parameters on the upper template can lead to a weird scroll to the lower templates header in the sidebar.

When hiding unused parameters, the sidebar should always scroll to the header of the template, where the parameters where hidden.

Details

Subject	Repo	Branch	Lines +/-
Simplify partly redundant findFirstSelectedItem implementation	mediawiki/extensions/VisualEditor	master	+8 -11
Extract template scrollToTop method	mediawiki/extensions/VisualEditor	master	+27 -6
Scroll template outline into view when hiding unused	mediawiki/extensions/VisualEditor	master	+20 -4

Customize query in gerrit

Related Objects

Mentioned In: T300640: Hide unused parameters by default in multi-part transclusions

Event Timeline

WMDE-Fisch created this task.Mar 3 2022, 10:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2022, 10:41 AM

• K8rill awarded a token.Mar 3 2022, 11:19 AM

WMDE-Fisch claimed this task.Mar 3 2022, 11:26 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-03-02 board.

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Mar 3 2022, 12:07 PM

WMDE-Fisch moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-03-02 board.

WMDE-Fisch claimed this task.Mar 4 2022, 8:56 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-03-02 board.

Change 768030 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Scroll template outline into view when hiding unused

https://gerrit.wikimedia.org/r/768030

gerritbot added a project: Patch-For-Review.Mar 4 2022, 11:05 AM

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-03-02 board.Mar 4 2022, 11:05 AM

WMDE-Fisch moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Mar 9 2022, 12:31 PM

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Mar 10 2022, 4:54 PM

Change 768030 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Scroll template outline into view when hiding unused

https://gerrit.wikimedia.org/r/768030

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 11 2022, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2022, 11:10 AM

Change 769945 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Extract template scrollToTop method

https://gerrit.wikimedia.org/r/769945

gerritbot added a project: Patch-For-Review.Mar 11 2022, 11:31 AM

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-03-02 board.Mar 11 2022, 11:33 AM

WMDE-Fisch closed this task as Resolved.Mar 15 2022, 9:22 AM

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-03-02 board.

WMDE-Fisch mentioned this in T300640: Hide unused parameters by default in multi-part transclusions.Mar 15 2022, 9:33 AM

Change 769945 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Extract template scrollToTop method

https://gerrit.wikimedia.org/r/769945

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 15 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2022, 1:10 PM

Change 818996 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Simplify partly redundant findFirstSelectedItem implementation

https://gerrit.wikimedia.org/r/818996

gerritbot added a project: Patch-For-Review.Aug 1 2022, 8:01 AM

Change 818996 merged by jenkins-bot: