Page MenuHomePhabricator

Deploy Wikistories extension to beta cluster
Closed, ResolvedPublic

Description

The Wikistories mediawiki extension is still in early development but there's a growing need by the broader pilot team to have it deployed in an environment more permanent than patch demo. Beta cluster seems like a good place for it but we're open to considering alternatives.

I'm not familiar with the specific steps involved (submodule?, branching?, etc) but I can try to figure it out with some guidance if it can help move this forward faster.

I can handle the config patch to enable the extension on specific beta wikis.

Wikistories repo

Event Timeline

Change 773211 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/tools/release@master] Start branching Wikistories for Wikimedia production

https://gerrit.wikimedia.org/r/773211

Change 773212 had a related patch set uploaded (by Sbisson; author: Sbisson):

[operations/mediawiki-config@master] Add Wikistories extension

https://gerrit.wikimedia.org/r/773212

Please note

it is strongly recommended to have a security readiness review performed prior to beta cluster deployment

from https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment.

@Zabe yes I've seen that. It's a chicken and egg situation for us. We are trying to build our features for the security review (planned for mid Q4) but not having a shared persistent environment is hurting our ability to do so. I will check with the security team to have an early pre-review / sanity check so we can hopefully move forward.

@Zabe we're discussing a pre security review in T301389. Are there steps that can be taken until then so we're able to be on beta as soon as they approve it?

Change 773334 had a related patch set uploaded (by Sbisson; author: Sbisson):

[operations/mediawiki-config@master] Enable Wikistories on enwiki beta

https://gerrit.wikimedia.org/r/773334

@Zabe yes I've seen that. It's a chicken and egg situation for us. We are trying to build our features for the security review (planned for mid Q4) but not having a shared persistent environment is hurting our ability to do so. I will check with the security team to have an early pre-review / sanity check so we can hopefully move forward.

I mainly wanted to make sure you are aware. A pre security review sounds like good way to me.

@Zabe we're discussing a pre security review in T301389. Are there steps that can be taken until then so we're able to be on beta as soon as they approve it?

Make sure the mediawiki/tools/release patch is merged early enough. Per https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment that should be done 'at least two weeks prior to your target date for enabling on the Beta Cluster'. That is because the extension needs to be present in all release branches used on production by the time the extension is added to extension-list.

Change 773211 merged by jenkins-bot:

[mediawiki/tools/release@master] Start branching Wikistories for Wikimedia production

https://gerrit.wikimedia.org/r/773211

SBisson edited projects, added Wikistories (Beta); removed Wikistories.

@Zabe thanks for merging the "Start branching.." task. Do you know if it was merged before or after the branch cut, and if the next step (Add extension) can be done? Thanks

@Zabe thanks for merging the "Start branching.." task. Do you know if it was merged before or after the branch cut, and if the next step (Add extension) can be done? Thanks

After.

You need to wait with procuding with the next step until the extension is present in all branches running on production, which is sadly going to take a bit.

[...]> You need to wait with procuding with the next step until the extension is present in all branches running on production, which is sadly going to take a bit.

Could you help me understand when we expect this and how to tell if it's the case?

[...]> You need to wait with procuding with the next step until the extension is present in all branches running on production, which is sadly going to take a bit.

Could you help me understand when we expect this and how to tell if it's the case?

There is a wmf branch branched each week and then deployed to production. wmf/1.39.0-wmf.6 is going to be the first branch which includes WikiStories (it is going to be branched on Tuesday the 5th of April).

You at least need to wait until that branch is running stable on all wikis. That should be the case on Monday the 11th of April.

I see that a wmf/1.39.0-wmf.5 branch was created today in the Wikistories repo. Does it change the timeline given above?

I see that a wmf/1.39.0-wmf.5 branch was created today in the Wikistories repo. Does it change the timeline given above?

I am sorry, it is not in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/wmf/1.39.0-wmf.5/extensions/ (created with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/774588), so no, the timeline does not change.

I guess someone created it manually?

Edit: I got confirmation over IRC that Jdforrester created it manually.

@Zabe checking for a status update on the deployment to beta for Wikistories? Thank you for letting us know

The branch should have been cut for the 2 weeks so this can now go ahead I believe as wmf.6.

Are you able to complete next steps or do you need support?

The branch should have been cut for the 2 weeks so this can now go ahead I believe as wmf.6.

Are you able to complete next steps or do you need support?

Thank you, I think we need to wait for the reviewers of https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/773212/ to give +2 and merge the patch.

Additional question, what should we do after the patch merge?

There's a few other steps that all can be done at once. (CommonSettings.php & InitaliseSettings.php, see https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Deploy_to_Beta_Cluster)

You will need to schedule the patch then for a deployment window. Does anyone in your team have access or do you need to communicate with a member of the team?

[...]
Are you able to complete next steps or do you need support?

We would need code review of the 2 config patches below. (Should they be combined into a single patch?) Then I can list it for a config deployment.
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/773212/
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/773334/

[...]
Are you able to complete next steps or do you need support?

We would need code review of the 2 config patches below. (Should they be combined into a single patch?) Then I can list it for a config deployment.

I can have a look and leave a +1 or comments. I prefer having them separately, it makes things easier to both review and deploy.

@Urbanecm sounds good. I'll try to list them for the "UTC afternoon backport window" today.

Change 773212 merged by jenkins-bot:

[operations/mediawiki-config@master] Add Wikistories extension

https://gerrit.wikimedia.org/r/773212

Change 773334 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Wikistories on enwiki beta

https://gerrit.wikimedia.org/r/773334

Mentioned in SAL (#wikimedia-operations) [2022-04-27T17:27:16Z] <urbanecm@deploy1002> Synchronized wmf-config/extension-list: 01dfaf063d14ee329c43d65566270ff3cec48d50: Add Wikistories extension (T303004) (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-04-27T17:28:08Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 88ac6b94ff5acfbcd6a539e21b7454b6a38eaaba: Enable Wikistories on enwiki beta (T303004; 1/2) (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-04-27T17:29:00Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: 88ac6b94ff5acfbcd6a539e21b7454b6a38eaaba: Enable Wikistories on enwiki beta (T303004; 2/2) (duration: 00m 50s)

SBisson claimed this task.