Page MenuHomePhabricator

Skin::buildSidebar shares cache between skins
Closed, ResolvedPublic

Description

The output of the various overridable methods called here, as well as the onSkinBuildSidebar() hook, may vary by skin. As such, the cache must take this into account.

The reason this has likely not been an issue with the majority of third party wikis that vary behaviour between skins, is that by configuration $wgEnableSidebarCache is disabled by default.

Event Timeline

Change 764416 had a related patch set uploaded (by Jdlrobson; author: Krinkle):

[mediawiki/core@master] skins: Fix Skin::buildSidebar to not share cache between skins

https://gerrit.wikimedia.org/r/764416

(Waiting on feedback about test)

Krinkle triaged this task as Medium priority.Mar 8 2022, 9:25 PM
Krinkle added a project: Performance-Team.
Krinkle lowered the priority of this task from Medium to Low.Sep 19 2022, 5:55 PM

Change 764416 merged by jenkins-bot:

[mediawiki/core@master] skins: Fix Skin::buildSidebar to not share cache between skins

https://gerrit.wikimedia.org/r/764416