Page MenuHomePhabricator

Timeouts in Karma while running our own QUnit tests blocking merges in DiscussionTools
Closed, ResolvedPublic

Description

We're unable to merge changes yet again… see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/758485

Failures look like this: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php73-noselenium-docker/48264/console

17:57:39   mw.dt.modifier
17:57:39     ✔ #addListItem/#removeAddedListItem case 0
17:57:39     ✔ #addListItem/#removeAddedListItem case 1
17:57:39     ✔ #addListItem/#removeAddedListItem case 2
17:57:43     ✔ #addListItem/#removeAddedListItem case 3
17:57:47 04 03 2022 16:57:53.192:DEBUG [Chrome Headless 90.0.4430.212 (Linux x86_64)]: Disconnected during run, waiting 2000ms for reconnecting.
17:57:53 04 03 2022 16:57:53.193:DEBUG [Chrome Headless 90.0.4430.212 (Linux x86_64)]: EXECUTING -> EXECUTING_DISCONNECTED
17:57:53 04 03 2022 16:57:55.197:WARN [Chrome Headless 90.0.4430.212 (Linux x86_64)]: Disconnected (0 times) reconnect failed before timeout of 2000ms (ping timeout)
17:57:55 Chrome Headless 90.0.4430.212 (Linux x86_64) ERROR
17:57:55   Disconnected reconnect failed before timeout of 2000ms (ping timeout)

The tests which time out are very large, they might genuinely take more than 2 seconds to complete. But why is this causing failures, and why did it start now?

There were similar issues in January, which we were able to avoid by splitting the assertions across multiple tests: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/753861

Event Timeline

Change 768134 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Disable the biggest JS modifier test cases temporarily

https://gerrit.wikimedia.org/r/768134

Change 768134 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Disable the biggest JS modifier test cases temporarily

https://gerrit.wikimedia.org/r/768134

matmarex claimed this task.

Oh well, we can just leave them disabled, I don't think anyone is going to work on this further.