Similar to T303102: Normalise PHP namespaces used in Vector
Most of the code is in MediaWiki\Minerva\. This also should probably be considered non standard (and inconsistent too) based on https://www.mediawiki.org/wiki/Best_practices_for_extensions#File_structure; however Minerva is sufficiently unique that this is allowed.
Tests are in Tests\MediaWiki\Minerva and MediaWiki\Skins\MinervaNeue\Tests\.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Normalise PHP namespaces used in MinervaNeue | mediawiki/skins/MinervaNeue | master | +25 -24 |
MediaWiki\Minerva\ is the namespace we should be using. I think this task can be called done by renaming the namespace in these files:
tests/phpunit/skins/SkinMinervaTest.php
tests/phpunit/LanguagesHelperTest.php
tests/phpunit/skins/SkinUserPageHelperTest.php
tests/phpunit/unit/SkinOptionsTest.php
tests/phpunit/menu/Entries/MenuEntryTest.php
tests/phpunit/permissions/MinervaPagePermissionsTest.php
tests/phpunit/menu/GroupTest.php
changed namespace Tests\MediaWiki\Minerva to namespace MediaWiki\Minerva in the following files, as requested:
Change 788760 had a related patch set uploaded (by EllenR; author: EllenR):
[mediawiki/skins/MinervaNeue@master] Normalise PHP namespaces used in MinervaNeue
Change 788760 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Normalise PHP namespaces used in MinervaNeue
Greetings @Jdlrobson I think @ERayfield has addressed the tasks of the ticket. Are there any other findings to be fixed?
Not from my perspective. I just noticed it is in product sign off on your kanban board and wanted to check if you need anything further from web team before resolving.
@Jdlrobson I will need to get caught up on what was done to address this ticket and will need to check with @ERayfield to see what is outstanding as I am totally out of the loop right now.
i've took a look at this and I'm pretty sure everything here is done. Please feel free to reopen if you feel that is not the case.