Page MenuHomePhabricator
Create Task
Maniphest T303122

Do not show toolbar if textbox is hidden.
Open, Needs TriagePublicBUG REPORT
Actions

Description

If a page is deleted while parallel editing is ongoing, EditPage will hide the textarea element and offer a checkbox to recreate the page with the to-be-saved content.

When that happens, WikiEditor should not output a toolbar of tools that cannot be used (as there's no textarea)

Screen Shot 2022-03-06 at 9.18.29 AM.png (361×1 px, 78 KB)

Details

SubjectRepoBranchLines +/-
Do not add toolbar when textbox is hiddenmediawiki/extensions/WikiEditormaster+4 -0
Customize query in gerrit

Event Timeline

Ammarpad created this task.Mar 6 2022, 8:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2022, 8:35 AM
gerritbot added a comment.Mar 7 2022, 3:56 PM

Change 768749 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/WikiEditor@master] Do not add toolbar when textbox is hidden

https://gerrit.wikimedia.org/r/768749

gerritbot added a project: Patch-For-Review.Mar 7 2022, 3:56 PM
gerritbot added a comment.Mar 21 2022, 6:41 AM

Change 768749 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Do not add toolbar when textbox is hidden

https://gerrit.wikimedia.org/r/768749

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.2; 2022-03-21-late).Mar 21 2022, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 21 2022, 7:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL