@Novem_Linguae What timezone have you set in Special:Preferences?

Los Angeles

Thanks for filing this. Moving to Triaged on the Growth-Team board as it's not something we're able to prioritize in the short-to-medium term.

Can still reproduce as of 11/09/22. Likely some kind of daylight savings time error.

After debugging, this appears to be caused by modules/ext.pageTriage.util/models/ext.pageTriage.article.js, line 28, offset = parseInt( mw.user.options.get( 'timecorrection' ).split( '|' )[ 1 ] ); Specifically, mw.user.options.get( 'timecorrection' ) is returning the wrong time correction for me.

More details at T323193. Basically this appears to be an upstream error and we'll need to wait on that ticket for the fix.

In T303124#8398691, @Novem_Linguae wrote:

After debugging, this appears to be caused by modules/ext.pageTriage.util/models/ext.pageTriage.article.js, line 28, offset = parseInt( mw.user.options.get( 'timecorrection' ).split( '|' )[ 1 ] ); Specifically, mw.user.options.get( 'timecorrection' ) is returning the wrong time correction for me.

More details at T323193. Basically this appears to be an upstream error and we'll need to wait on that ticket for the fix.

I wrote a comment in T323193#8399658, I don't see anything obviously wrong in the code, and I don't think a recently merged patch might have caused that. Most importantly, I think the logic in PageTriage is wrong/fragile. Instead of using the offset, it should check if the timezone is geographical, and use that to compute the correct offset.

Most importantly, I think the logic in PageTriage is wrong/fragile. Instead of using the offset, it should check if the timezone is geographical, and use that to compute the correct offset.

That can't be done in JavaScript except by using bulky libraries like moment-timezone. PageTriage uses the DST-corrected timezone offset which the backend is supposed to export in mw.user.options.get( 'timecorrection' ).

In T303124#8407331, @SD0001 wrote:

Most importantly, I think the logic in PageTriage is wrong/fragile. Instead of using the offset, it should check if the timezone is geographical, and use that to compute the correct offset.

That can't be done in JavaScript except by using bulky libraries like moment-timezone. PageTriage uses the DST-corrected timezone offset which the backend is supposed to export in mw.user.options.get( 'timecorrection' ).

Good point, I didn't realize that JavaScript has nonexistent support for IANA timezones... I think exposing the offset from the server-side is not the best solution though. Lack of timezone parsing in JavaScript seems a more fundamental issue that would benefit from a different solution, one that could be reused elsewhere. Maybe something like a library, although possibly smaller than momentjs (which is also no longer maintained I think).

Change 860646 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/GlobalPreferences@master] GlobalPrefs should apply same options corrections as core

https://gerrit.wikimedia.org/r/860646

Timezone bug in PageTriage Special:NewPagesFeed is back for me. All times are one hour behind the actual time. Probably because USA recently switched to daylight savings time (spring forward), and an offset being stored somewhere was not updated.

In T303124#9009169, @TheresNoTime wrote:

Stalling on Patch-For-Review

Should be Patch-Needs-Improvement though, but no problem, I rebased it.