Page MenuHomePhabricator
Create Task
Maniphest T303131

Librarise Libs/JsonSchemaValidation or replace
Open, Needs TriagePublic
Actions

Description

Either the Libs/JsonSchemaValidation inside EventLogging should be moved out to a library, or if possible, one of the existing json schema libraries in MediaWiki-Vendor (opis/json-schema or justinrainbow/json-schema) should be used instead.

It seems various of the classes in Libs/JsonSchemaValidation have ancestry back in MediaWiki-extensions-JsonData; if we Librarize this code, we can use Composer to include the classes into both (and MediaWiki-Vendor for WMF production), rather than having duplicate code.

It's unclear if opis/json-schema or justinrainbow/json-schema can replace this code in either case, but at least factoring it out into a library would be a good step in the right direction... See also T293710: Migrate from justinrainbow/json-schema to opis/json-schema and remove from MW vendor

Related Objects

Event Timeline

Reedy created this task.Mar 6 2022, 3:25 PM
Restricted Application added a project: Data-Engineering. · View Herald TranscriptMar 6 2022, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a comment.EditedMar 6 2022, 3:47 PM

Noting a few of these classes are used outside of EventLogging.

And there's the MediaWiki-extensions-JsonData which has numerous similarly named classes... See also T303132: Archive the JsonData extension

Reedy added a project: MediaWiki-extensions-JsonData.Mar 7 2022, 4:46 AM
Reedy updated the task description. (Show Details)
Reedy added a comment.Mar 7 2022, 4:51 AM

If someone has a better idea if opis/json-schema or justinrainbow/json-schema (preferably the latter) can replace the code, rather than factoring it out.. That'd be useful to know

Reedy updated the task description. (Show Details)Mar 7 2022, 4:54 AM
• EChetty moved this task from Incoming (new tickets) to Apache Iceberg Migration on the Data-Engineering board.Mar 24 2022, 3:22 PM
• EChetty assigned this task to Ottomata.Mar 24 2022, 5:08 PM
Ottomata added a comment.Mar 24 2022, 5:10 PM

WMF is trying to stop using on wiki schemas for EventLogging. From our perspective, we can and should remove any support in EventLogging for on wiki JSONSchemas. However there may be 3rd party wikis that use on wiki JSONSchemas via EventLogging, so I'm not sure if we can just do this.

In either case, removing JSONSChema support from EventLogging extension will be blocked until T259163: Migrate legacy metawiki schemas to Event Platform is totally finished anyway.

phuedx mentioned this in T306059: Migrate Metrics Platform PHP library from justinrainbow/json-schema to opis/json-schema.Apr 13 2022, 4:51 PM
phuedx removed a subtask: T306059: Migrate Metrics Platform PHP library from justinrainbow/json-schema to opis/json-schema.Apr 13 2022, 6:43 PM
JArguello-WMF moved this task from Apache Iceberg Migration to Radar (External Teams) on the Data-Engineering board.Jun 29 2023, 11:35 PM
JArguello-WMF moved this task from Radar (External Teams) to Event Platform Backlog on the Data-Engineering board.Jun 29 2023, 11:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL