Author: neilk
Description:
Waiting for the tutorial and other page elements to show up can be irritating. Show a spinner to indicate something is happening.
Version: unspecified
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz28315
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T38680 Upload Wizard release "elvis" (tracking) | |||
| Resolved | None | T29260 UploadWizard 1.0 (tracking) | |||
| Resolved | kaldari | T30315 Show a spinner on initial load |
Event Timeline
Comment Actions
neilk wrote:
When I tried this on commons.prototype the spinner appeared above the UploadWizard and did not go away.
Check your solution again with an empty cache?
Comment Actions
Works for me in Firefox 4 and Safari. Are we testing the same page:
http://commons.prototype.wikimedia.org/wiki/Special:UploadWizard
Comment Actions
neilk wrote:
screenshot of problem on Mac OS X Chrome 10
See attachment.
I believe the problem is twofold:
- When debug mode is off (as on prototype) ResourceLoader is going to load the spinner image and the rest of everything at the same time, within the same HTTP call. So if that's delayed, while RL packages something maybe, there's no benefit.
- Something else about the way this loads is causing jQuery to get confused about making it visible. Possibly, since the div actually has zero content, it doesn't think it has to hide() it.
Attached:
Comment Actions
neilk wrote:
Also, another thing -- the spinner shouldn't be shown immediately. Otherwise we get a nasty flashing effect sometimes. It should only appear if the loading has taken more than 2 seconds. Easy to do with a timeout.
Comment Actions
neilk wrote:
Okay, a bit of thrashing occurred as Kaldari and I overwrote each other's changes/ideas/concepts/whatever, but this appears to be fixed in r85517.